Allow to configure line endings and indentation

[digulla]

Allow to configure line endings and indentation used in the DefaultPrettyPrinter plus test cases.

[cowtowncoder]

Sounds good, but I do worry about one thing -- removing a public class is a backwards-compatiblity-breaking change, so anyone who is using it (either directly or by sub-classing) would get their code broken. Would it be possible to just leave a deprecated type, which could extend the new class?

[digulla]

You're right, of course. I've restored the old API (I hope I didn't miss anything) plus extended the new API a bit.

I'm also thinking about a way to allow to define a custom pretty printer in ObjectMapper. What do you think?

[cowtowncoder]

@digulla Custom pretty printer can already be configured via ObjectWriter. The goal is to move most if not all configuration into ObjectWriter, due to thread safety. I am not against adding a baseline setting for ObjectMapper (setDefaultPrettyPrinter()) if that seems useful.

[cowtowncoder]

Ok; I can merge this, just one last piece of process: we need a filled Contributor License Agreement (CLA):

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(unless I have asked and gotten one -- I don't think I have, but just in case).

A filled copy is needed just once for all contributions, but we need it for the first merge.
So if you could print, fill, scan and email it to info at fasterxml dot com, that'd be great?

[digulla]

Re: ObjectWriter vs. ObjectMapper: I thought everyone was supposed to go via the ObjectMapper API and ObjectWriter was more of an internal API?

[cowtowncoder]

No, not at all. Perhaps your impression is due to ObjectMapper having been there since beginning, but ObjectWriter and ObjectReader having been added later? Due to immutability and thread-safety, latter are nowadays preferably over mapper; ObjectMapper can be seen more as a factory for readers and writers.

But much of documentation does show direct usage via ObjectMapper still.

[cowtowncoder]

Merged, thanks again!