-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
More work on #1498, now cover handling of annotated-but-mode-less case
- Loading branch information
1 parent
f939280
commit a1c4cbc
Showing
3 changed files
with
267 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
177 changes: 177 additions & 0 deletions
177
src/test/java/com/fasterxml/jackson/databind/deser/creators/ConstructorDetector1498Test.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| package com.fasterxml.jackson.databind.deser.creators; | ||
|
|
||
| import java.lang.annotation.*; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
|
|
||
| import com.fasterxml.jackson.databind.*; | ||
| import com.fasterxml.jackson.databind.cfg.*; | ||
| import com.fasterxml.jackson.databind.exc.InvalidDefinitionException; | ||
| import com.fasterxml.jackson.databind.introspect.AnnotatedMember; | ||
| import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector; | ||
| import com.fasterxml.jackson.databind.json.JsonMapper; | ||
|
|
||
| // Tests for [databind#1498] (Jackson 2.12) | ||
| public class ConstructorDetector1498Test extends BaseMapTest | ||
| { | ||
| // Helper annotation to work around lack of implicit name access with Jackson 2.x | ||
| @Target(ElementType.PARAMETER) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @interface ImplicitName { | ||
| String value(); | ||
| } | ||
|
|
||
| // And annotation introspector to make use of it | ||
| @SuppressWarnings("serial") | ||
| static class CtorNameIntrospector extends JacksonAnnotationIntrospector | ||
| { | ||
| @Override | ||
| public String findImplicitPropertyName(//MapperConfig<?> config, | ||
| AnnotatedMember member) { | ||
| final ImplicitName ann = member.getAnnotation(ImplicitName.class); | ||
| return (ann == null) ? null : ann.value(); | ||
| } | ||
| } | ||
|
|
||
| static class SingleArgNotAnnotated { | ||
| protected int v; | ||
|
|
||
| // SingleArgNotAnnotated() { throw new Error("Should not be used"); } | ||
|
|
||
| public SingleArgNotAnnotated(int value) { | ||
| v = value; | ||
| } | ||
| } | ||
|
|
||
| static class SingleArgNoMode { | ||
| protected int v; | ||
|
|
||
| // SingleArgNoMode() { throw new Error("Should not be used"); } | ||
|
|
||
| @JsonCreator | ||
| public SingleArgNoMode(@ImplicitName("value") int value) { | ||
| v = value; | ||
| } | ||
| } | ||
|
|
||
| private final ObjectMapper MAPPER_PROPS = mapperFor(ConstructorDetector.USE_PROPERTIES_BASED); | ||
| private final ObjectMapper MAPPER_DELEGATING = mapperFor(ConstructorDetector.USE_DELEGATING); | ||
| private final ObjectMapper MAPPER_EXPLICIT = mapperFor(ConstructorDetector.EXPLICIT_ONLY); | ||
|
|
||
| /* | ||
| /********************************************************************** | ||
| /* Test methods, selecting from 1-arg constructors, properties-based | ||
| /********************************************************************** | ||
| */ | ||
|
|
||
| /* | ||
| public void test1ArgDefaultsToPropertiesNonAnnotated() throws Exception | ||
| { | ||
| SingleArgNotAnnotated value = MAPPER_PROPS.readValue(a2q("{'value' : 137 }"), | ||
| SingleArgNotAnnotated.class); | ||
| assertEquals(137, value.v); | ||
| } | ||
| */ | ||
|
|
||
| public void test1ArgDefaultsToPropertiesNoMode() throws Exception | ||
| { | ||
| // and similarly for mode-less | ||
| SingleArgNoMode value = MAPPER_PROPS.readValue(a2q("{'value' : 137 }"), | ||
| SingleArgNoMode.class); | ||
| assertEquals(137, value.v); | ||
| } | ||
|
|
||
| /* | ||
| /********************************************************************** | ||
| /* Test methods, selecting from 1-arg constructors, delegating | ||
| /********************************************************************** | ||
| */ | ||
|
|
||
| /* | ||
| public void test1ArgDefaultsToDelegatingNoAnnotation() throws Exception | ||
| { | ||
| // No annotation, fail | ||
| try { | ||
| MAPPER_DELEGATING.readValue(" 2812 ", SingleArgNotAnnotated.class); | ||
| fail("Should not pass"); | ||
| } catch (Exception e) { | ||
| verifyException(e, "foobar"); | ||
| } | ||
| } | ||
| */ | ||
|
|
||
| public void test1ArgDefaultsToDelegatingNoMode() throws Exception | ||
| { | ||
| // One with `@JsonCreator` no mode annotation (ok since indicated) | ||
| SingleArgNoMode value = MAPPER_DELEGATING.readValue(" 2812 ", SingleArgNoMode.class); | ||
| assertEquals(2812, value.v); | ||
| } | ||
|
|
||
| /* | ||
| /********************************************************************** | ||
| /* Test methods, selecting from 1-arg constructors, other | ||
| /********************************************************************** | ||
| */ | ||
|
|
||
| public void test1ArgDefaultsToHeuristics() throws Exception | ||
| { | ||
| final ObjectMapper mapper = mapperFor(ConstructorDetector.DEFAULT); | ||
| final String DOC = " 13117 "; | ||
|
|
||
| // First: unannotated is ok, defaults to delegating | ||
| SingleArgNotAnnotated v1 = mapper.readValue(DOC, SingleArgNotAnnotated.class); | ||
| assertEquals(13117, v1.v); | ||
|
|
||
| // and ditto for mode-less | ||
| SingleArgNoMode v2 = mapper.readValue(DOC, SingleArgNoMode.class); | ||
| assertEquals(13117, v2.v); | ||
| } | ||
|
|
||
| /* | ||
| public void test1ArgFailsNoAnnotation() throws Exception | ||
| { | ||
| // First: fail if nothing annotated (for 1-arg case) | ||
| try { | ||
| MAPPER_EXPLICIT.readValue(" 2812 ", SingleArgNotAnnotated.class); | ||
| fail("Should not pass"); | ||
| } catch (Exception e) { | ||
| verifyException(e, "foobar"); | ||
| } | ||
| } | ||
| */ | ||
|
|
||
| public void test1ArgFailsNoMode() throws Exception | ||
| { | ||
| // Second: also fail also if no "mode" indicated | ||
| try { | ||
| MAPPER_EXPLICIT.readValue(" 2812 ", SingleArgNoMode.class); | ||
| fail("Should not pass"); | ||
| } catch (InvalidDefinitionException e) { | ||
| verifyException(e, "no 'mode' defined"); | ||
| verifyException(e, "SingleArgConstructor.REQUIRE_MODE"); | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| /********************************************************************** | ||
| /* Test methods | ||
| /********************************************************************** | ||
| */ | ||
|
|
||
| /* | ||
| /********************************************************************** | ||
| /* Helper methods | ||
| /********************************************************************** | ||
| */ | ||
|
|
||
| private JsonMapper.Builder mapperBuilder() { | ||
| return JsonMapper.builder() | ||
| .annotationIntrospector(new CtorNameIntrospector()); | ||
| } | ||
|
|
||
| private ObjectMapper mapperFor(ConstructorDetector cd) { | ||
| return mapperBuilder() | ||
| .constructorDetector(cd) | ||
| .build(); | ||
| } | ||
| } |