Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder Deserialization with Type Binding (#921) #1796

Merged

Conversation

vjkoskela
Copy link
Contributor

Extend support for deserializing via builder if the builder has type bindings by inferring those bindings from the value type. This behavior is not ideal, but addresses the common case, and is controlled by a MapperFeature. This is intended to begin to address the issue described in #921.

@cowtowncoder
Copy link
Member

Ok I should get that merged. Just one question: addition of the new method in TypeFactory is probably the only thing I am bit concerned about. I think it's ok to add but could use javadoc.
And a unit test or two that would help document it, too, esp. if testing also done with incompatible case (different number of parameters)?

@vjkoskela
Copy link
Contributor Author

Apologies for not following up on this sooner. I will add some javadoc and tests as soon as possible. Thanks for taking a look!

…bindings by inferring those bindings from the value type. This behavior is not ideal, but addresses the common case, and is controlled by a MapperFeature.
@vjkoskela vjkoskela force-pushed the deser-builder-generics-latest branch from e19083c to 12161af Compare January 5, 2018 06:31
@vjkoskela
Copy link
Contributor Author

Added some javadoc and tests. Let me know how that looks!

@cowtowncoder
Copy link
Member

Apologies for slow follow-up here. I think it looks better. I think the only test that could be useful to add would be negative test, to see what happens with incompatible TypeBindings... but not sure how much that can be validated (or if).

@cowtowncoder cowtowncoder merged commit 3501f29 into FasterXML:master Mar 19, 2018
@cowtowncoder
Copy link
Member

Note: now also backported to 2.12 (to be included in 2.12.0)

@vjkoskela
Copy link
Contributor Author

Fantastic! Thank you.

@sumannewton
Copy link

@cowtowncoder @vjkoskela Is this released? I am waiting for this fix. If not released, when can we expect this?

@cowtowncoder
Copy link
Member

@sumannewton As per issue itself, #921 (this is PR), it will be in 2.12.0. 2.12 is still being developed, and will be released "when it's ready": releases are not scheduled on time-basis.
At this point I think that the first release candidate could be released earliest in August, and ideally no later than September. Release usually follows within about a month.
So probably in September/October 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants