Allow `@JsonAnySetter` on Creators #4558

JooHyukKim · 2024-06-01T13:00:39Z

resolves #562

This version is more adherent to existing call flow and simply extends existing implementations, such as....

Introduction of SettableAnyProperty subclasses JsonNodeParameterAnyProperty and MapParameterAnyProperty
Introduction of SettableAnyProperty methods getParameterIndex() createParameterObject() to streamline deserialization by PropertyValueBuffer

Also suggestions from PR #4366 have been followed

Added support for JsonNode and ObjectNode
Added tests for record also

…rops()

…r can just pour into the any-setter

cowtowncoder · 2024-06-01T16:17:43Z

Excellent progress! Hoping to review this in detail (had a quick look, much improved from what I already saw -- and not just wrt addressing things I mentioned but overall)

cowtowncoder · 2024-06-02T22:10:31Z

FWTW, this is part of one of two listed "major design/implementation issues" page:

https://github.com/FasterXML/jackson-future-ideas/wiki/Major-Design---Implementation-Issues

so not "just" one of top-voted Mostly Wanted features but also considered a significant design/implementation concern.

cowtowncoder · 2024-06-08T00:43:41Z

src/main/java/com/fasterxml/jackson/databind/deser/BasicDeserializerFactory.java

-            if (name == null) {
+            boolean isAnySetter = Boolean.TRUE.equals(ctxt.getAnnotationIntrospector().hasAnySetter(param));
+            if (isAnySetter) {
+                if (anySetterFound) {


Looks like we lose information on any-setter, and only call introspector to find multiples here... but then need to re-introspect later on?

I remembered now, this code serves two purposes.

One is to detect and handle multiple any-setter (which, as you said, could be moved to later one below)

The other one, which I do need help with is... not any-setter not having any property name here. So any-setter creator parameter without any name specified (via @JsonProperty) throws error.

LMK if you have better idea with the second problem I am facing, @cowtowncoder

Ah. Yes. For that purpose, we could only do a lookup if name not found. Let me think about this a bit, good point, something is needed here.

src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializerFactory.java

src/main/java/com/fasterxml/jackson/databind/deser/SettableAnyProperty.java

src/main/java/com/fasterxml/jackson/databind/deser/impl/PropertyValueBuffer.java

…Property

src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializer.java

…cks for Field vs Ctor Parameter)

…t null/missing checks)

src/test/java/com/fasterxml/jackson/databind/deser/creators/AnySetterForCreator562Test.java

…any-creator params

JooHyukKim · 2024-06-09T02:38:14Z

Phew, that was alot of work 😆 Hopefully, it won't be too hard merging into master.
Thank you for your help! @cowtowncoder

cowtowncoder · 2024-06-09T03:30:43Z

@JooHyukKim thank you for actually implementing it & going through all tiny things I wanted changed :)

Surprisingly merge to master was quite straight-forward this time around.

And with this, we are getting somewhat close to 2.18.0 minimum feature set, as far as I care.
I do want this performance optimization: FasterXML/jackson-core#1284 for streaming but otherwise not many must-haves.

JooHyukKim added 9 commits June 1, 2024 13:39

Implement all

10e60b9

Order methods in PropertyBasedCreator

b9b43f3

Clean up anySetter discovery during building beanDeserialier.addBeanP…

2ec9140

…rops()

Implement separate constructCreatorPropertyAnySetter()

ee9afc0

refactor: fix indents

adb5d1e

feature: Add index field to SettableAnyProperty so PropertyValueBuffe…

fb36d8e

…r can just pour into the any-setter

test : Add record tests

40aaf88

Add support for ObjectNode

c66ca73

Clean up rest of the code

326e491

JooHyukKim mentioned this pull request Jun 1, 2024

Allow @JsonAnySetter on Creator constructors #4366

Closed

JooHyukKim added 4 commits June 1, 2024 22:02

Merge branch '2.18' into 562-version2

c076683

Refactor : simplify implementations

bf91015

Another clean up

7d40a43

Update SettableAnyProperty.java

b96725c

JooHyukKim changed the title ~~Allow @JsonAnySetter on Creator constructors~~ Allow @JsonAnySetter on Creators Jun 1, 2024

cowtowncoder mentioned this pull request Jun 1, 2024

deserialized JsonAnySetter field is null #4508

Closed

1 task

cowtowncoder added 3 commits June 2, 2024 17:05

Merge branch '2.18' into 562-version2

0792312

Merge branch '2.18' into 562-version2

346ff29

Merge branch '2.18' into 562-version2

a0da86f

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializerFactory.java Show resolved Hide resolved

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/deser/SettableAnyProperty.java Outdated Show resolved Hide resolved

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/deser/SettableAnyProperty.java Outdated Show resolved Hide resolved

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/deser/impl/PropertyValueBuffer.java Outdated Show resolved Hide resolved

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/deser/impl/PropertyValueBuffer.java Outdated Show resolved Hide resolved

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/deser/impl/PropertyValueBuffer.java Outdated Show resolved Hide resolved

JooHyukKim added 2 commits June 8, 2024 21:31

Revise comment and throw UnsupportedOperationException in SettableAny…

0e11a15

…Property

Replace _consumedFlag, by actually using ProeprtyValue class

d678cb4

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializer.java Show resolved Hide resolved

cowtowncoder added 5 commits June 8, 2024 10:16

Minor comment addition

e910875

Minor renaming, reordering, to unify handling (same order of type che…

93ad870

…cks for Field vs Ctor Parameter)

One more comment add

b3a37ef

minor comment improvement

b5ef0d3

Update tests slightly: no 1 failure as behavior not quite correct (wr…

6cefc8e

…t null/missing checks)

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/test/java/com/fasterxml/jackson/databind/deser/creators/AnySetterForCreator562Test.java Show resolved Hide resolved

cowtowncoder reviewed Jun 8, 2024

View reviewed changes

src/test/java/com/fasterxml/jackson/databind/deser/creators/AnySetterForCreator562Test.java Show resolved Hide resolved

cowtowncoder added 5 commits June 8, 2024 17:05

Extend tests, fix an issue with combined buffering of non-creator vs …

e05336d

…any-creator params

Update release notes

b482bd8

Fix the failing test

22952bb

Minor error reporting improvement

01c0cc5

Test improvement

34c0411

cowtowncoder merged commit 65a00fd into FasterXML:2.18 Jun 9, 2024
8 checks passed

cowtowncoder added most-wanted Tag to indicate that there is heavy user +1'ing action 2.18 labels Jun 9, 2024

cowtowncoder added this to the 2.18.0 milestone Jun 9, 2024

JooHyukKim deleted the 562-version2 branch June 9, 2024 02:38

yihtserns mentioned this pull request Jul 23, 2024

@JsonAnySetter on field ignoring unrecognized properties if they are declared before the last recognized properties in JSON #4639

Closed

1 task

JooHyukKim mentioned this pull request Oct 29, 2024

Kotlin object deserialization with @JsonCreator fails in Jackson 2.18.0 FasterXML/jackson-module-kotlin#841

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `@JsonAnySetter` on Creators #4558

Allow `@JsonAnySetter` on Creators #4558

JooHyukKim commented Jun 1, 2024 •

edited

Loading

cowtowncoder commented Jun 1, 2024

cowtowncoder commented Jun 2, 2024 •

edited

Loading

cowtowncoder Jun 8, 2024

JooHyukKim Jun 8, 2024

JooHyukKim Jun 8, 2024

cowtowncoder Jun 8, 2024

JooHyukKim commented Jun 9, 2024

cowtowncoder commented Jun 9, 2024

Allow @JsonAnySetter on Creators #4558

Allow @JsonAnySetter on Creators #4558

Conversation

JooHyukKim commented Jun 1, 2024 • edited Loading

cowtowncoder commented Jun 1, 2024

cowtowncoder commented Jun 2, 2024 • edited Loading

cowtowncoder Jun 8, 2024

Choose a reason for hiding this comment

JooHyukKim Jun 8, 2024

Choose a reason for hiding this comment

JooHyukKim Jun 8, 2024

Choose a reason for hiding this comment

cowtowncoder Jun 8, 2024

Choose a reason for hiding this comment

JooHyukKim commented Jun 9, 2024

cowtowncoder commented Jun 9, 2024

Allow `@JsonAnySetter` on Creators #4558

Allow `@JsonAnySetter` on Creators #4558

JooHyukKim commented Jun 1, 2024 •

edited

Loading

cowtowncoder commented Jun 2, 2024 •

edited

Loading