Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jackson3.0] Fix #4845: change SerializationFeature.WRITE_DATES_AS_TIMESTAMPS to false in 3.0 #4946

Merged
merged 5 commits into from
Feb 5, 2025
Merged

[Jackson3.0] Fix #4845: change SerializationFeature.WRITE_DATES_AS_TIMESTAMPS to false in 3.0 #4946

merged 5 commits into from
Feb 5, 2025
+34 −17

Conversation

JooHyukKim
Copy link
Member

resolves #4845

@cowtowncoder
Copy link
Member

cowtowncoder commented Feb 5, 2025 •
edited
Loading

Thanks! We will almost certainly need significant prs for Joda (#4946) and Java 8 date/time as well? I'll see how bad that'd be locally.

EDIT: for Joda, not super bad -- just 5 failures. I'll tackle those now. -- Done.

EDIT: for Java 8 date/time it's also only 21 failures (out of 709) which is less than I expected. Maybe I'll just merge this in now & we can solve issues post-merge.

@cowtowncoder cowtowncoder merged commit 961c128 into FasterXML:master Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JooHyukKim @cowtowncoder