Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to run JDK 17 (Records) tests optionally, similar to jackson-databind #671

Closed
cowtowncoder opened this issue Oct 9, 2024 · 2 comments · Fixed by #672
Closed
Labels
2.18 Issues planned at earliest for 2.18

Comments

@cowtowncoder
Copy link
Member

(note: offshoot from #517)

Currently we cannot add test cases for Record-handling, in Jackson 2.x, due to JDK baseline being Java 8 still.
But there is a way to do this; used f.ex by jackson-databind.
This is relatively simple by:

  1. Adding tests under src/test-jdk17/java/
  2. Using specific Maven profile to conditionally include this test source directory if (and only if) running on JDK 17+

It'd be good to be able to add specific Records-with-XML test cases.

@cowtowncoder cowtowncoder added the 2.18 Issues planned at earliest for 2.18 label Oct 9, 2024
@cowtowncoder
Copy link
Member Author

cc @JooHyukKim WDYT?

@JooHyukKim
Copy link
Member

JooHyukKim commented Oct 9, 2024

Yup, totatlly makes sense. I can spare some time today, to set things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.18 Issues planned at earliest for 2.18
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants