Add JDK 17 test functionality #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried manually failing jdk 17 to see if it works via e60e5f9. Works fine 👌🏼 |
cowtowncoder
approved these changes
Oct 10, 2024
|
Oh shoot. This was agaisnt 2.17 for some reason? I don't think we really needed that... although I guess that's ok. |
|
@cowtowncoder My bad 🙉 I forgot to point out about the base branch. extension modules tend to get updated less frequently so there will be more people reporting issues from earlier version, so I figured might as well get merged into reasonably earlier version. |
|
My bad for not asking for re-base. Problem/challenge here was just merging, We are very unlikely to backport fixes in 2.17 for any modules. Still, it's all good, got it merged and we have it even for 2.17 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #671