Add logback-test.xml to test/resources in the Avro Module
#380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In versions 2.15 and above, the logback-test.xml file was being included as part of the release artifact because it was packaged in the main resources folder instead of the test resources folder. By moving the config file to the test resources folder, it will keep the test output reasonable while not impacting any logback applications which pull in this module as a dependency
cowtowncoder
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions 2.15 and above, the
logback-test.xmlfile was being included as part of the release artifact because it was packaged in themain/resourcesfolder instead of thetest/resourcesfolder. By moving the config file to the test resources folder, it will keep the test output reasonable while not impacting any logback applications which pull in this module as a dependency.This pull request is in response to the discussion in #379