-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #386 Option to add .ignorePropery() to Csv builder #418
Conversation
Added new method CsvSchema.ignoreProperty() to define the properties that need to be removed for the csv.
Updated the feature branch with the latest code corrections from the base branch. |
@djay-S I may be wrong, but I suspect this does not quite do what #386 is asking: I think it asks for something that would work similar to how But I hope @membersound can clarify details of how he thinks feature should work. |
@cowtowncoder I have made changes for not removing the column definitions and only ignoring the columns. Let me know if the changes are valid. |
Exactly: I simply need a method that behaves like |
* @param ignoreProperties Array of column names to be ignored by the csv builder | ||
* @return A newly built {@link CsvSchema} with the ignored properties | ||
*/ | ||
public CsvSchema ignoreProperty(String[] ignoreProperties) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From naming perspective it should probably be "ignoreProperties".
Also, would perhaps make sense to take String...
instead of String[]
for convenience.
@djay-S My concern is whether this does what is being requested, and from @membersound 's comment I suspect it does not: removing column from @membersound you may be able to try this out by building Leaving this open for now but may close in future unless it is thought to actually solve the problem. |
I don't think this makes sense, closing. |
Added new method CsvSchema.ignoreProperty() to define the properties that need to be removed for the csv.
Issue: #386