Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LocalDateTime Support via Extensions (Issue #100) #105

Closed
wants to merge 0 commits into from

Conversation

Shounaks
Copy link
Contributor

@Shounaks Shounaks commented Jul 9, 2023

relates to #100

@cowtowncoder
Copy link
Member

This looks like a good starting point, but one quick note: instead of adding code to existing Maven sub-projects (general jr-objects, annotation-support), this would need to be a new sub-project/module.

Like jr-extension-datetime (for example). It'd depend on jr-objects and could be depended on (and registered) by projects that need it.
I'd prefer this over adding limited functionality in core; this allows plugging alternate implementations, and publishing new versions of datatype extensions quicker if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants