Partially shaded Bytebuddy classes found under META-INF/versions/9 in jackson-module-mrbean-3.0.0.jar

[seadbrane]

The shading of byte-buddy in mrbean has left the multi-release byte-buddy classes in META-INF/versions/9 directory. The class name was updated, but the class file name was not, which is leading to classpath conflicts with ByteBuddy itself.

javap META-INF/versions/9/net/bytebuddy/ByteBuddy.class
Compiled from "ByteBuddy.java"
public class tools.jackson.module.mrbean.bytebuddy.ByteBuddy {
  public static final java.lang.String DEFAULT_NAMING_PROPERTY;
  public static final java.lang.String DEFAULT_VALIDATION_PROPERTY;
  protected final tools.jackson.module.mrbean.bytebuddy.ClassFileVersion classFileVersion;

The byte-buddy module-info was also included and module name and exports were not updated. This is also a quite old version of bytebuddy.

javap META-INF/versions/9/module-info.class
module net.bytebuddy@1.15.11 {
  requires static java.instrument;
  requires static java.management;
  requires static jdk.unsupported;
  requires static net.bytebuddy.agent;
  requires static com.sun.jna;
  requires static com.sun.jna.platform;
  requires java.base;

There are also these other bytebuddy artifacts in META-INF, which probably shouldn't be there:

META-INF/maven/net.bytebuddy
META-INF/maven/net.bytebuddy/byte-buddy
META-INF/maven/net.bytebuddy/byte-buddy/pom.properties
META-INF/maven/net.bytebuddy/byte-buddy/pom.xml

[cowtowncoder]

Which Jackson version(s)? I assume 3.0.0 or 3.0.1 (since BB conversion happened for Jackson 3)

[seadbrane]

yes - see jar name in title - both 3.0.0 and 3.0.1.

[cowtowncoder]

yes - see jar name in title - both 3.0.0 and 3.0.1.

Lol. Sorry, yes, that is in fact obvious now :)

@geoand Sorry to bother you again but I think you might be able to help here?

I should be able to update ByteBuddy version if that matters (will do that next) but not sure about Shade plugin, module definition.

EDIT: #317 updated BB in 3.x.

[seadbrane]

ByteBuddy version doesn't matter that much, just happened to noticed that it was rather old - and its always good to update dependencies that you can when creating new major versions.

The shading is the real issue and not sure there are tools that will correctly update module-info or multiple-release jar classes.
An easy option is to filter these out - especially module-info, although since jackson 3.0 is jdk17+ it would be better for it to use the versions/9 classes instead of the standard ones - which are for JDK 1.5.

[cowtowncoder]

@seadbrane right. Did not realize byte-buddy itself was MR. Depending on what overrides are for, could indeed just drop -- if performance, for example, BB usage should not be on critical path.

[seadbrane]

Or if ByteBuddy is critical maybe include it as a dependency instead of shading it.

[cowtowncoder]

Another possibility, BB seems nicely compatible across versions. #282 removed BB shading from Afterburner.

However, that is kind of change that ideally won't be done in a patch so for 3.0.2 would be good to solve by changing inclusion I think.

[geoand]

Oh nice, I did not know this issue at all :). This sounds like a bug in shade plugin, no?

[cowtowncoder]

@geoand Plausible, combination of MR and shading can be problematic.

[geoand]

Exactly my thoughts