-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/#116 - Removes the fraction part based on the SerializationFeature WRITE_TIMESTAMP_WITHOUT_FRACTION #164
Conversation
* test: add initial test case * fix: fix problems in test case for issue #1 * feat: add test cases for timestamps part and nanoseconds part related to issue #1 * create a false test cases #1 * Use flag for diabling fraction * Use flag for diabling fraction * Added the flag for DurationSerializer classes * Removed test cases that are not relevant to the added Serialization Feature * Only keep requirement specific tests Some tests were set up to get an understanding of the code. They should not be kept and included in the pull request Co-authored-by: Nagisa <fuchang.2000@gmail.com> Co-authored-by: Jacob Adlers <jacob.adlers@gmail.com>
Since this is updating the databind module, the build will fail. We couldnt find information on how to update changes in multiple modules. |
@kupci May I know if we can address your comments and update the PR? Will it be still relevant? |
@sashikanthr I think the issue is still relevant, but it might be easier to create a new PR. I think your original PR highlighted the need for a better overall solution for handling issues like these. One thought (refreshing myself on the issue) was to use the However, on that subject @cowtowncoder describes some initial thoughts / Idea-lets here:
https://github.com/FasterXML/jackson-future-ideas/wiki/JSTEP-5 One question I have is whether we can simply add more some sub-types, i.e. we already have updated: See the newly added CoercionConfig - wondering if that can be used as @cowtowncoder - not sure how to update the JSTEP wiki. On the jackson-databind/wiki there is an 'Edit' button, and a 'New Page', but I don't see that for the corresponding wiki page on 'Future Ideas', specifically the JSTEP-5 page: https://github.com/FasterXML/jackson-future-ideas/wiki/JSTEP-5] |
So, As to possible Finally, on wiki: @kupci should now have access via "wiki" team (you may need to accept it or something, requested your addition) so hopefully can now edit that wiki page. |
Thanks @cowtowncoder , that worked: I can get see the "Edit" button on the new-ideas wiki. |
Closing this one as per comments above, the direction for changes like this is to implement via a more long-term solution. Details here: https://github.com/FasterXML/jackson-future-ideas/wiki/JSTEP-5 |
This fixes #116
We have added a new feature to in SerializationFeature in the databind package to avoid the fraction part. This has a separate pull request.