Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade to moditect 1.1.0 #179

Closed
wants to merge 1 commit into from
Closed

downgrade to moditect 1.1.0 #179

wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Member

see FasterXML/jackson-databind#4727 (comment) and subsequent comments

@cowtowncoder
Copy link
Member

Let's hold off from this widespread changes before discussing things via FasterXML/jackson-databind#4727 (probably to be moved).
I want to understand better issues and where change is needed -- TL;DNR sounds like override would be needed for jackson-core and not for other jars. There were, I think, actual fixes in 1.2.x over 1.1.x too.

@pjfanning
Copy link
Member Author

The real fix here is to get Eclipse to fix JDT.

@pjfanning pjfanning closed this Oct 4, 2024
@pjfanning pjfanning deleted the pjfanning-patch-1 branch October 4, 2024 18:19
@cowtowncoder cowtowncoder restored the pjfanning-patch-1 branch October 5, 2024 00:29
@cowtowncoder
Copy link
Member

cowtowncoder commented Oct 5, 2024

Actually, based on comments on databind ticket, it does sound like problem affects about everything BUT jackson-core. And while I agree that Eclipse should fix their stuff, I think your initial suggestion makes sense.

And the only (?) question is whether to apply change here or in jackson-parent.
Here would cover all cases so probably best.

EDIT: realized one thing: new oss-parent version does require new jackson-parent anyway. So probably this is better to do via jackson-parent as an override and leave oss-parent alone (why better? Just because jackson-parent versioning is aligned with Jackson releases, oss-parent not).

Yet another possibility would be jackson-base which all Jackson components extend except for jackson-annotations.

@cowtowncoder
Copy link
Member

@pjfanning Let's do this for jackson-parent (branch 2.18) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants