Filter logs #27
Open
Filter logs #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fattouche
reviewed
Jul 13, 2018
src/cumulus/cli.py
Outdated
| with open(LOGFILE, 'a') as log_file: | ||
| print ('Initializing {0}...'.format(service)) | ||
| subprocess.call([DOCKER_COMPOSE, "run", service, "INIT"], stdout=log_file, stderr=subprocess.STDOUT) | ||
| subprocess.call([DOCKER_COMPOSE, "rm", "-f", service], stdout=log_file, stderr=subprocess.STDOUT) |
There was a problem hiding this comment.
Should we check if there was an error before we say it was initialized?
Fattouche
reviewed
Jul 13, 2018
src/cumulus/cli.py
Outdated
| subprocess.call([DOCKER_COMPOSE, "up", "-d", service]) | ||
| print ('{0} Started!'.format(service)) |
There was a problem hiding this comment.
I think this is outdated, I provide the url they can hit to see the web app.
There was a problem hiding this comment.
It is outdated. I have to merge manually, so that's probably one of the reasons why.
|
|
|
Do we just want to leave it then? Doesn't matter to me. |
Fattouche
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.