Changed wording of setDTR(), clearDTR, setRTS(), and clearRTS() to re… #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duce confusion when used with common USB-UART bridges.
…d with USB serial adapters and Arduino/esp32 boards.
…ud rates > 230400 on Apple computers & elaborate upon the constraints imposed by USB-serial adapters upon baudrate selection. USB-serial baudrate is one of those things that generally "just works" at or below 115200 baud, but can fail at faster rates for reasons that aren't intuitive or obvious until you discover that the data is "really" being transferred across the USB bus in 64-byte chunks once per millisecond.
… there can be ONLY ONE DataListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated javadocs for setDTR(), clearDTR(), setRTS(), and clearRTS() to reduce confusion when library is used to drive common USB-UART bridges like the SiLabs CP210x family (where DTR and RTS are active low, so asserting them to 1 drives the pin low, and clearing it to 0 drives it high).
Sources:
https://www.silabs.com/documents/public/data-sheets/cp2102n-datasheet.pdf page 28 (which states that DTR and RTS are active low)
the book "Serial Port Complete" (page 364), which describes RTS and DTR as