Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_good_clusters_for_concat should have extra args #23

Closed
josephwb opened this issue Jun 6, 2018 · 2 comments
Closed

find_good_clusters_for_concat should have extra args #23

josephwb opened this issue Jun 6, 2018 · 2 comments

Comments

@josephwb
Copy link
Member

josephwb commented Jun 6, 2018

It has become abundantly clear that a global conf.py does not work for every clade. Specifically:

smallest_cluster
cluster_prop

Presently find_good_clusters_for_concat.py just uses the values from conf.py. It is a bit of a pain to edit the latter while troubleshooting. It would be nice if the former used these values by default but could be overridden by optional args. This should be easy with the switch to argparse (#14).

@Cactusolo
Copy link

@josephwb I see two options are added:

usage: find_good_clusters_for_concat.py -d DIR -b DATABASE [-i]

#-d : define where is path to your cluster data generated by setup_clade.py
#-b the path leading to your plantDB

now the gif in the tutorial and here need to be updated.

thanks!

Miao

@josephwb
Copy link
Member Author

josephwb commented May 2, 2019

Much of this has been resolved with bdedfe7 to have better defaults. It would still be nice to provide custom parameters for weirdo. I can do this if it proves to be useful.

@josephwb josephwb closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants