commits from bitcoin/master #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t local Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.
Reject messages are logged to debug.log if NET debug logging is enabled. Because of the way the `ProcessMessages()` function is structured, processing for REJECT messages will also drop through to the default branch and incorrectly log `Unknown command "reject" from peer-?`. Fix that by exiting from `ProcessMessages()` early. without this PR: ``` 2018-05-03T17:37:00.930600Z received: reject (21 bytes) peer=0 2018-05-03T17:37:00.930620Z Reject message code 16: spammy spam 2018-05-03T17:37:00.930656Z Unknown command "reject" from peer=0 ``` with this PR: ``` 2018-05-03T17:35:04.751246Z received: reject (21 bytes) peer=0 2018-05-03T17:35:04.751274Z Reject message code 16: spammy spam ```
CWallet::ScanForWalletTransactions did not previously take into account pindexStop when calculating progress. Renamed progress vars to progress_*. rescanblockchain is the only rpc that uses this parameter.
9a75d29 change the error result from `PIE` to `DYNAMIC_BASE`. And there are no test for 64-bit, so I made one
FeatherCoin
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear which functions that are intended to be translation unit local
bitcoin/bitcoin#13163
mempool: Add compile time checking for ::mempool.cs runtime locking assertions
bitcoin/bitcoin#13080
[net] Don't incorrectly log that REJECT messages are unknown.
bitcoin/bitcoin#13162
Fix re-declared scoped enum as unscoped (Causes issues with some compilers)
bitcoin/bitcoin#13180
Handle unsuccessful fseek(...):s
bitcoin/bitcoin#13149
Add Windows shutdown handler
bitcoin/bitcoin#13131
Fix rescanblockchain rpc to properly report progress
bitcoin/bitcoin#13079
tests: Add test for 64-bit Windows PE, modify 32-bit test results
bitcoin/bitcoin#13094
RPC Docs: gettxout*: clarify bestblock and unspent counts
bitcoin/bitcoin#13184