Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deploy] Report worker's connectivity when it finished. #2157

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

Raphael-Jin
Copy link
Collaborator

No description provided.

fedml-dimitris
fedml-dimitris previously approved these changes Jun 11, 2024
@fedml-dimitris fedml-dimitris requested a review from alaydshah June 11, 2024 19:55
@Raphael-Jin Raphael-Jin changed the base branch from dev/v0.7.0 to master June 11, 2024 22:59
@Raphael-Jin Raphael-Jin dismissed fedml-dimitris’s stale review June 11, 2024 22:59

The base branch was changed.

@Raphael-Jin Raphael-Jin changed the base branch from master to dev/v0.7.0 June 11, 2024 22:59
Copy link

gitguardian bot commented Jun 11, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9453265 Triggered Generic High Entropy Secret 060eef6 python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret c05f23a python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret 3417f30 python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret 52b5b2d python/fedml/workflow/driver_example/main.py View secret
9453265 Triggered Generic High Entropy Secret c607ce6 python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret 2bbe2f9 python/fedml/api/api_test.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Raphael-Jin Raphael-Jin merged commit 34fdba0 into dev/v0.7.0 Jun 11, 2024
0 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants