Upload Byte data #2196
Open
Upload Byte data #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaydshah
reviewed
Jun 21, 2024
alaydshah
reviewed
Jun 21, 2024
alaydshah
reviewed
Jun 21, 2024
|
To summarize, we should try to make following modifications:
|
alaydshah
reviewed
Jun 22, 2024
| @@ -92,7 +67,8 @@ def upload(data_path, api_key, name, description, tag_list, service, show_progre | |||
| } | |||
|
|
|||
| try: | |||
| response = _create_dataset(api_key=api_key, json_data=json_data) | |||
| response = _create_dataset(api_key=api_key, json_data=json_data, encrypted_api_key_flag=encrypted_api_key_flag) | |||
| print("create dataset ", response) | |||
There was a problem hiding this comment.
Why we need to print here?
alaydshah
reviewed
Jun 22, 2024
| @@ -120,7 +96,7 @@ def download(data_name, api_key, service, dest_path, show_progress=True) -> FedM | |||
| download_url = metadata.download_url | |||
| given_extension = os.path.splitext(data_name)[1] | |||
| is_file = True | |||
| if(given_extension is None or given_extension ==""): | |||
| if (given_extension is None or given_extension == ""): | |||
There was a problem hiding this comment.
if not given_extension:
|
Please remember to always propogate the newly added variables all the way up to CLIs and APIs. This is the entrypoint, and we don't have the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable uploading byte data through fedml storage upload command.