Refactor healthcheck test to make it easier to read

horust/src/horust/healthcheck/mod.rs

@@ -153,10 +153,6 @@ mod test {
     use crate::horust::formats::{Healthiness, HealthinessStatus};
     use crate::horust::healthcheck::check_health;
 
-    fn check_health_w(healthiness: &Healthiness) -> bool {
-        check_health(healthiness) == HealthinessStatus::Healthy
-    }
-
     #[test]
     fn test_healthiness_check_file() -> Result<()> {
         let tempdir = TempDir::new("health")?;
@@ -166,11 +162,11 @@ mod test {
             http_endpoint: None,
             ..Default::default()
         };
-        assert!(!check_health_w(&healthiness));
+        assert_ne!(check_health(&healthiness), HealthinessStatus::Healthy);
         std::fs::write(file_path, "Hello world!")?;
-        assert!(check_health_w(&healthiness));
+        assert_eq!(check_health(&healthiness), HealthinessStatus::Healthy);
         let healthiness: Healthiness = Default::default();
-        assert!(check_health_w(&healthiness));
+        assert_eq!(check_health(&healthiness), HealthinessStatus::Healthy);
         Ok(())
     }
 
@@ -193,7 +189,7 @@ mod test {
             http_endpoint: Some("http://localhost:123/".into()),
             ..Default::default()
         };
-        assert!(!check_health_w(&healthiness));
+        assert_ne!(check_health(&healthiness), HealthinessStatus::Healthy);
         let loopback = Ipv4Addr::new(127, 0, 0, 1);
         let socket = SocketAddrV4::new(loopback, 0);
         let listener = TcpListener::bind(socket)?;
@@ -209,11 +205,11 @@ mod test {
             handle_request(listener).unwrap();
             sender.send(()).expect("Chan closed");
         });
-        assert!(check_health_w(&healthiness));
+        assert_eq!(check_health(&healthiness), HealthinessStatus::Healthy);
         receiver
             .recv_timeout(Duration::from_millis(2000))
             .expect("Failed to received response from handle_request");
-        assert!(!check_health_w(&healthiness));
+        assert_ne!(check_health(&healthiness), HealthinessStatus::Healthy);
         Ok(())
     }
 }