Skip to content

Commit

Permalink
eclipse-rdf4jGH-4243: minor corrections for docker instructions
Browse files Browse the repository at this point in the history
Signed-off-by:Bart Hanssens <bart.hanssens@bosa.fgov.be>
  • Loading branch information
barthanssens committed Oct 26, 2022
1 parent c646d1d commit f3d44b5
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 8 deletions.
24 changes: 16 additions & 8 deletions docker/README_DEV.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,21 @@ Documentation for building and distributing the docker image containing the Serv
Run `./run.sh` to build and start the server and workbench. This will invoke the `build.sh` script.

### Full build (build.sh)
Before building the docker image we need to get hold of the WAR files. These are built when
the maven project is assembled and packed in the sdk ZIP-file under `assembly/target`.

The Dockerfile expects that the SDK ZIP-file is copied and renamed as `ignore/rdf4j.zip`.
The simplest way to build the image and tag it, is to run the `build.sh` script.

Building the docker image can be done with a docker command directly, but it's easier to use
docker-compose instead.
This script will perform the following tasks:

Once the image is built it needs to be tagged as `eclipse/rdf4j-workbench:${maven.project.version}`.
1. Before building the docker image the WAR files need to be available. These are built when
the maven project is assembled and the result is packed in the SDK ZIP-file under `assembly/target`.

2. The SDK ZIP-file is copied and renamed as `ignore/rdf4j.zip` (as required by the Dockerfile script).

3. Building the docker image can be done with a docker command directly,
but the script takes an alternative approach and uses docker-compose instead.

4. Once the image is built, it is tagged as `eclipse/rdf4j-workbench:${maven.project.version}`.

The simplest way to accomplish all of the above is to run the `build.sh` script.

### Running up the docker container (docker-compose)

Expand Down Expand Up @@ -74,6 +78,9 @@ Push the image:

`VERSION_TAG` is the version (tag) you want to push, e.g. `4.3.0`

Note that hub.docker.com does not update the `latest` tag automatically,
the newly created image has also to be tagged `latest` and pushed to hub.docker.com.

### Method 2: multi-platform docker image using buildx

Since the base image being used is available for multiple architectures,
Expand All @@ -95,4 +102,5 @@ Build and push the image (note the `.` at the end of the command):

`VERSION_TAG` is the version (tag) you want to push, e.g. `4.3.0`


Note that hub.docker.com does not update the `latest` tag automatically,
the newly created image has also to be tagged `latest` and pushed to hub.docker.com.
4 changes: 4 additions & 0 deletions site/content/documentation/developer/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,10 @@ Push the image:

`VERSION_TAG` is the version (tag) you want to push, e.g. `4.3.0`

Note that hub.docker.com does not update the `latest` tag automatically,
the newly created image has also to be tagged `latest` and pushed to hub.docker.com.


### Method 2: multi-platform docker image using buildx

Since the base image being used is available for multiple architectures,
Expand Down

0 comments on commit f3d44b5

Please sign in to comment.