Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall previous version when installing to same directory #664

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Uninstall previous version when installing to same directory #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dist/win/mediawriter.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ function .onInit
functionEnd

section "install"
; Uninstall previous version when installing to same directory
ExecWait '"$INSTDIR\uninstall.exe" /S _?=$INSTDIR'

# Files for the install directory - to build the installer, these should be in the same directory as the install script (this file)
SetOutPath $INSTDIR
SetOverwrite on
Expand Down Expand Up @@ -209,7 +212,7 @@ sectionEnd
SetShellVarContext all

#Verify the uninstaller - last chance to back out
MessageBox MB_OKCANCEL "Permanently remove ${APPNAME}?" IDOK next
MessageBox MB_OKCANCEL "Do you want to uninstall ${APPNAME}?" IDOK next
Abort
next:
!insertmacro VerifyUserIsAdmin
Expand Down
5 changes: 4 additions & 1 deletion dist/win/mediawriter_native.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ function .onInit
functionEnd

section "install"
; Uninstall previous version when installing to same directory
ExecWait '"$INSTDIR\uninstall.exe" /S _?=$INSTDIR'

# Files for the install directory - to build the installer, these should be in the same directory as the install script (this file)
SetOutPath $INSTDIR
SetOverwrite on
Expand Down Expand Up @@ -209,7 +212,7 @@ sectionEnd
SetShellVarContext all

#Verify the uninstaller - last chance to back out
MessageBox MB_OKCANCEL "Permanently remove ${APPNAME}?" IDOK next
MessageBox MB_OKCANCEL "Do you want to uninstall ${APPNAME}?" IDOK next
Abort
next:
!insertmacro VerifyUserIsAdmin
Expand Down
Loading