Driver: Retune threadpool keepalive time #157
FelixMcFelixAnnotations
39 warnings
|
this argument is a mutable reference, but not used mutably:
src/input/metadata/mod.rs#L51
warning: this argument is a mutable reference, but not used mutably
--> src/input/metadata/mod.rs:51:37
|
51 | pub fn from_ffprobe_json(value: &mut [u8]) -> Result<Self, JsonError> {
| ^^^^^^^^^ help: consider changing to: `&[u8]`
|
= warning: changing this function will impact semver compatibility
= note: this is cfg-gated and may require further changes
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default
|
|
matching over `()` is more explicit:
src/manager.rs#L256
warning: matching over `()` is more explicit
--> src/manager.rs:256:41
|
256 | Ok(chan) => chan.await.map(|_| call),
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/input/adapters/raw_adapter.rs#L77
warning: matching over `()` is more explicit
--> src/input/adapters/raw_adapter.rs:77:42
|
77 | self.inner.rewind().map(|_| 0)
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
docs for function which may panic missing `# Panics` section:
src/input/adapters/raw_adapter.rs#L26
warning: docs for function which may panic missing `# Panics` section
--> src/input/adapters/raw_adapter.rs:26:5
|
26 | pub fn new(audio_source: A, sample_rate: u32, channel_count: u32) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/input/adapters/raw_adapter.rs:30:9
|
30 | / write_space
31 | | .write_u32::<LittleEndian>(sample_rate)
32 | | .expect("Prepend buffer is sized to include enough space for sample rate.");
| |_______________________________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
matching over `()` is more explicit:
src/input/adapters/child.rs#L81
warning: matching over `()` is more explicit
--> src/input/adapters/child.rs:81:37
|
81 | let attempt = attempt.and_then(|_| {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/input/adapters/cached/compressed.rs#L403
warning: matching over `()` is more explicit
--> src/input/adapters/cached/compressed.rs:403:24
|
403 | Ok(_) => {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
docs for function which may panic missing `# Panics` section:
src/input/adapters/cached/compressed.rs#L128
warning: docs for function which may panic missing `# Panics` section
--> src/input/adapters/cached/compressed.rs:128:5
|
128 | / pub async fn with_config(
129 | | source: Input,
130 | | bitrate: Bitrate,
131 | | config: Option<Config>,
132 | | ) -> Result<Self, CodecCacheError> {
| |______________________________________^
|
note: first possible panic found here
--> src/input/adapters/cached/compressed.rs:205:9
|
205 | / (&mut metabytes[4..][..mem::size_of::<i32>()])
206 | | .write_i32::<LittleEndian>(meta_len)
207 | | .expect("Magic byte writing location guaranteed to be well-founded.");
| |_________________________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
matching over `()` is more explicit:
src/input/adapters/async_adapter.rs#L305
warning: matching over `()` is more explicit
--> src/input/adapters/async_adapter.rs:305:52
|
305 | None => self.check_dropped().ok().map(|_| unreachable!()),
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/input/adapters/async_adapter.rs#L287
warning: matching over `()` is more explicit
--> src/input/adapters/async_adapter.rs:287:47
|
287 | None => self.check_dropped().map(|_| unreachable!()),
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/input/adapters/async_adapter.rs#L277
warning: matching over `()` is more explicit
--> src/input/adapters/async_adapter.rs:277:47
|
277 | None => self.check_dropped().map(|_| unreachable!())?,
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/input/adapters/async_adapter.rs#L86
warning: matching over `()` is more explicit
--> src/input/adapters/async_adapter.rs:86:70
|
86 | fs.push(Either::Right(self.notify_rx.notified().map(|_| {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
manual `Debug` impl does not include all fields:
src/info.rs#L148
warning: manual `Debug` impl does not include all fields
--> src/info.rs:148:1
|
148 | / impl fmt::Debug for Partial {
149 | | fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
150 | | f.debug_struct("Partial")
151 | | .field("channel_id", &self.channel_id)
... |
156 | | }
157 | | }
| |_^
|
note: this field is unused
--> src/info.rs:142:5
|
142 | pub guild_id: GuildId,
| ^^^^^^^^^^^^^^^^^^^^^
note: this field is unused
--> src/info.rs:145:5
|
145 | pub user_id: UserId,
| ^^^^^^^^^^^^^^^^^^^
= help: consider including all fields in this `Debug` impl
= help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug
= note: `#[warn(clippy::missing_fields_in_debug)]` implied by `#[warn(clippy::pedantic)]`
|
|
matching over `()` is more explicit:
src/handler.rs#L307
warning: matching over `()` is more explicit
--> src/handler.rs:307:23
|
307 | .map(|_| JoinGateway::new(rx.into_recv_async(), timeout))
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/handler.rs#L244
warning: matching over `()` is more explicit
--> src/handler.rs:244:23
|
244 | .map(|_| Join::new(rx.into_recv_async(), gw_rx.into_recv_async(), timeout))
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
use of `or_insert_with` to construct default value:
src/events/store.rs#L173
warning: use of `or_insert_with` to construct default value
--> src/events/store.rs:173:52
|
173 | let holder = self.awaiting_tick.entry(evt).or_insert_with(Vec::new);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
|
use of `or_insert_with` to construct default value:
src/events/store.rs#L68
warning: use of `or_insert_with` to construct default value
--> src/events/store.rs:68:22
|
68 | .or_insert_with(Vec::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
|
use of `or_insert_with` to construct default value:
src/events/store.rs#L62
warning: use of `or_insert_with` to construct default value
--> src/events/store.rs:62:22
|
62 | .or_insert_with(Vec::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
|
docs for function which may panic missing `# Panics` section:
src/events/context/data/rtp.rs#L26
warning: docs for function which may panic missing `# Panics` section
--> src/events/context/data/rtp.rs:26:5
|
26 | pub fn rtp(&'_ self) -> RtpPacket<'_> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/events/context/data/rtp.rs:27:9
|
27 | / RtpPacket::new(&self.packet)
28 | | .expect("FATAL: leaked illegally small RTP packet from UDP Rx task.")
| |_________________________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
docs for function which may panic missing `# Panics` section:
src/events/context/data/rtcp.rs#L24
warning: docs for function which may panic missing `# Panics` section
--> src/events/context/data/rtcp.rs:24:5
|
24 | pub fn rtcp(&'_ self) -> RtcpPacket<'_> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/events/context/data/rtcp.rs:25:9
|
25 | / RtcpPacket::new(&self.packet)
26 | | .expect("FATAL: leaked illegally small RTP packet from UDP Rx task.")
| |_________________________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
docs for function which may panic missing `# Panics` section:
src/driver/mod.rs#L309
warning: docs for function which may panic missing `# Panics` section
--> src/driver/mod.rs:309:5
|
309 | / pub fn enqueue_with_preload(
310 | | &mut self,
311 | | track: Track,
312 | | preload_time: Option<Duration>,
313 | | ) -> TrackHandle {
| |____________________^
|
note: first possible panic found here
--> src/driver/mod.rs:314:21
|
314 | let queue = self.queue.take().expect(
| _____________________^
315 | | "Enqueue: The only case this can fail is if a previous queue operation panicked.",
316 | | );
| |_________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
|
docs for function which may panic missing `# Panics` section:
src/driver/mod.rs#L283
warning: docs for function which may panic missing `# Panics` section
--> src/driver/mod.rs:283:5
|
283 | pub fn queue(&self) -> &TrackQueue {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/driver/mod.rs:284:9
|
284 | / self.queue
285 | | .as_ref()
286 | | .expect("Queue: The only case this can fail is if a previous queue operation panicked.")
| |____________________________________________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
= note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
|
|
matching over `()` is more explicit:
src/driver/tasks/ws.rs#L85
warning: matching over `()` is more explicit
--> src/driver/tasks/ws.rs:85:17
|
85 | _ = hb => {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/driver/tasks/udp_rx/mod.rs#L100
warning: matching over `()` is more explicit
--> src/driver/tasks/udp_rx/mod.rs:100:17
|
100 | _ = tokio::time::sleep_until(cleanup_time) => {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/driver/tasks/udp_rx/mod.rs#L73
warning: matching over `()` is more explicit
--> src/driver/tasks/udp_rx/mod.rs:73:17
|
73 | _ = tokio::time::sleep_until(playout_time) => {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
it is more concise to loop over references to containers instead of using explicit iteration methods:
src/driver/tasks/mixer/mix_logic.rs#L379
warning: it is more concise to loop over references to containers instead of using explicit iteration methods
--> src/driver/tasks/mixer/mix_logic.rs:379:24
|
379 | for s_plane in source[..].iter() {
| ^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&source[..]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
|
|
it is more concise to loop over references to containers instead of using explicit iteration methods:
src/driver/tasks/mixer/mix_logic.rs#L367
warning: it is more concise to loop over references to containers instead of using explicit iteration methods
--> src/driver/tasks/mixer/mix_logic.rs:367:24
|
367 | for d_plane in (*target.planes_mut().planes()).iter_mut() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&mut (*target.planes_mut().planes())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
|
|
it is more concise to loop over references to containers instead of using explicit iteration methods:
src/driver/tasks/mixer/mix_logic.rs#L324
warning: it is more concise to loop over references to containers instead of using explicit iteration methods
--> src/driver/tasks/mixer/mix_logic.rs:324:24
|
324 | for s_plane in source_raw_planes[..].iter() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&source_raw_planes[..]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
|
|
it is more concise to loop over references to containers instead of using explicit iteration methods:
src/driver/tasks/mixer/mix_logic.rs#L310
warning: it is more concise to loop over references to containers instead of using explicit iteration methods
--> src/driver/tasks/mixer/mix_logic.rs:310:24
|
310 | for d_plane in (*target.planes_mut().planes()).iter_mut() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&mut (*target.planes_mut().planes())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
= note: `#[warn(clippy::explicit_iter_loop)]` implied by `#[warn(clippy::pedantic)]`
|
|
matching over `()` is more explicit:
src/driver/scheduler/task.rs#L155
warning: matching over `()` is more explicit
--> src/driver/scheduler/task.rs:155:27
|
155 | .map(|_| should_exit)
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/driver/scheduler/live.rs#L276
warning: matching over `()` is more explicit
--> src/driver/scheduler/live.rs:276:28
|
276 | .and_then(|_| mixer.check_and_send_keepalive(self.start_of_work));
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/driver/scheduler/idle.rs#L164
warning: matching over `()` is more explicit
--> src/driver/scheduler/idle.rs:164:24
|
164 | Ok(_) => {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/driver/scheduler/idle.rs#L97
warning: matching over `()` is more explicit
--> src/driver/scheduler/idle.rs:97:44
|
97 | ... Ok(true) | Err(_) => self.to_cull.push(id),
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
|
matching over `()` is more explicit:
src/driver/crypto.rs#L152
warning: matching over `()` is more explicit
--> src/driver/crypto.rs:152:19
|
152 | .map(|_| (body_start, body_tail))
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
note: the lint level is defined here
--> src/lib.rs:65:9
|
65 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::ignored_unit_patterns)]` implied by `#[warn(clippy::pedantic)]`
|
|
private item shadows public glob re-export:
src/input/adapters/cached/mod.rs#L18
warning: private item shadows public glob re-export
--> src/input/adapters/cached/mod.rs:18:21
|
18 | use streamcatcher::{Config, GrowthStrategy};
| ^^^^^^
|
note: the name `Config` in the type namespace is supposed to be publicly re-exported here
--> src/input/adapters/cached/mod.rs:12:16
|
12 | pub use self::{compressed::*, decompressed::*, error::*, hint::*, memory::*};
| ^^^^^^^^^^^^^
note: but the private item here shadows it
--> src/input/adapters/cached/mod.rs:18:21
|
18 | use streamcatcher::{Config, GrowthStrategy};
| ^^^^^^
= note: `#[warn(hidden_glob_reexports)]` on by default
|
|
Publish docs
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Publish docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Publish docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Publish docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Publish docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|