Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Slider added in Home #124

Closed
wants to merge 15 commits into from
Closed

Automated Slider added in Home #124

wants to merge 15 commits into from

Conversation

WebVishal
Copy link
Contributor

@WebVishal WebVishal commented Mar 23, 2021

hi@khushishikhu I have added the Automated slider please check the code and merge it in the main branch
I have added a short clip

Issue no #118

02.mp4

@khushishikhu
Copy link
Member

@WebVishal please solve the merge conflicts

@vercel
Copy link

vercel bot commented Mar 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/feminine-devine/periodoo/HALJ42RfRHFWsA1YCPdDrL45ruXo
✅ Preview: https://periodoo-git-fork-webvishal-master-feminine-devine.vercel.app

[Deployment for eacc106 failed]

@WebVishal
Copy link
Contributor Author

hi @khushishikhu, I have fixed the conflict issue, review the code

@khushishikhu khushishikhu added gssoc21 Issues for GirlSript Summer of Code Level3 New feature, Major Bug fixing labels Mar 26, 2021
@khushishikhu
Copy link
Member

@WebVishal I have checked your PR the images are good but the orientation of the image doesn't seem proper as the should be only one image to display in one slide and bit the some portion of the next image slide. And also can you just decrease the height of the images because it is taking the whole screen currently. Please make these suggested changes so that I will happily merge this. Hope you got my point, if you need any help do ping us , we will sort out✌️

@WebVishal
Copy link
Contributor Author

@khushishikhu When I Decrease the height of the image, then the background behind it is not seen properly, can I remove it? and "started component" add on slider images

@khushishikhu
Copy link
Member

@WebVishal Background of the webpage, you mean to say?

@WebVishal
Copy link
Contributor Author

hi @khushishikhu, After the height of the image is reduced and some modifications look like this

VIDEO_2ad980e4-ad58-4530-98d2-8e4480827b33.mp4

@WebVishal
Copy link
Contributor Author

hi @khushishikhu, can review the code

@khushishikhu
Copy link
Member

@WebVishal Hey can you please update this branch. And can you just set the images in a way that the content should not overlap with the images it has on the webpage.

@WebVishal
Copy link
Contributor Author

hi @khushishikhu Can I work on this is the issue or it is closed
Sorry I was busy with my freelancer project for the last 2 to 3 weeks now I want to contribute to this project can I work on this issue again

@khushishikhu
Copy link
Member

@WebVishal Sorry as you were inactive for so many days. I have assigned this issue to someone else. you can take any other issue where no one is working.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 Issues for GirlSript Summer of Code Level3 New feature, Major Bug fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants