Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact us form email.js #228

Closed

Conversation

akshay1027
Copy link
Contributor

Description

Issue FIXES #185

Describe the changes you've made

changed div tag to Form tag, used the form "on submitting" method to handle forms and state! added subject input box as well!

Screenshots:

2021-04-23 (3)

2021-04-23 (4)

Checklist

  • I have added my name in the contributors list at the end of README.md file.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.
  • Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

@akshay1027
Copy link
Contributor Author

@Aaishpra @khushishikhu The emailjs setup is same as in this article( https://medium.com/weekly-webtips/simple-react-contact-form-without-back-end-9fa06eff52d9 ) but I have used a different method to handle forms! Also, don't forget to set up the .enn files as well! Let me know about the changes!

@khushishikhu khushishikhu added gssoc21 Issues for GirlSript Summer of Code Level3 New feature, Major Bug fixing labels Apr 24, 2021
@khushishikhu
Copy link
Member

@akshay1027 can you please write the instructions in the Readme.md of how to set up the .env file

@akshay1027
Copy link
Contributor Author

akshay1027 commented Apr 24, 2021

I myself, don't know how to use .env files in next js and also in frontend. Or else I would have done that as well. I would be happy to learn from you! While I tested, I directly used the API keys... @khushishikhu @Aaishpra

@Aaishpra
Copy link
Member

@K-Kumar-01 can you help with this.

@akshay1027
Copy link
Contributor Author

@Aaishpra we first have to setup the mail, so we have to do it in email.js website, if you can give me your mail and password, I can do this for you. I have asked @khushishikhu but have not got any reply yet

@akshay1027
Copy link
Contributor Author

akshay1027 commented Apr 26, 2021

@khushishikhu said there can be any security issues, so What I suggested is create a seperate google account for managing this , we can use that mail account, let me know if you have any better idea @Aaishpra @K-Kumar-01

@Aaishpra
Copy link
Member

I get it, and i think this can be done after someone reviews the code for us @akshay1027 first we need to finalize (might use a dummy id for this) and when every thing works fine we can go forward using the organisation's email, which can be done by me or @khushishikhu

@akshay1027
Copy link
Contributor Author

akshay1027 commented Apr 26, 2021

Cool! Got it 🙌🏻

@K-Kumar-01
Copy link
Collaborator

@akshay1027
Is it possible for you to record a small video demonstrating the working of the code?

@akshay1027
Copy link
Contributor Author

Okay I will try 🙌🏻, you guys tested it ? Facing any problems ?

@akshay1027
Copy link
Contributor Author

https://www.youtube.com/watch?v=NgWGllOjkbs check out this video , i learnt from here @K-Kumar-01

@K-Kumar-01
Copy link
Collaborator

https://www.youtube.com/watch?v=NgWGllOjkbs check out this video , i learnt from here @K-Kumar-01

@akshay1027
This seems fine to me, but before merging we need to set up the .env file as well as update the PR to avoid conflicts.
As for the env file here is a link that I think might be helpful.

@Aaishpra the code seems fine to me. I think the key needs to be generated for which you can have a discussion with @akshay1027

@akshay1027
Copy link
Contributor Author

@khushishikhu even if I set up the .env file, will I be able to push it? I think we cant push files which proceeds with dot "
."

@vercel
Copy link

vercel bot commented Apr 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/feminine-divine/periodo/GBeuysm1BbaSjFj1CxxFC68wEgnN
✅ Preview: https://periodo-git-fork-akshay1027-contactus-form-emailj-b5c278.vercel.app

@akshay1027
Copy link
Contributor Author

i have made the changes and tested it @khushishikhu @K-Kumar-01! now you just have to add API keys in the .env file :)

@K-Kumar-01
Copy link
Collaborator

@khushishikhu even if I set up the .env file, will I be able to push it? I think we cant push files which proceeds with dot "
."

@akshay1027
One can push .env files but it is not advisable to push such files as they contain sensitive information. I think @Aaishpra or @khushishikhu will do that part. However, can you please resolve the conflicts?

@akshay1027
Copy link
Contributor Author

conflicts resolved

@Aaishpra
Copy link
Member

Thanks for this @akshay1027 i will be free in a day or two and then we can have discussion on discord about this. Thanks for your patience

@khushishikhu
Copy link
Member

khushishikhu commented May 15, 2021

@akshay1027 can you please resolve the conflicts. Then I will add the credentials of .env file after merging this PR. It is actually working quite well. Thank you for your efforts

@akshay1027
Copy link
Contributor Author

Hey @khushishikhu, am not able to resolve the yarn.lock and package-lock files, My laptop is getting hanged whenever I open them! Can you please resolve them

@khushishikhu
Copy link
Member

@akshay1027 I see there are so many conflicts and difficult to resolve. If you are comfortable can you please open another PR like this one only to not face this thing.

@akshay1027
Copy link
Contributor Author

akshay1027 commented May 19, 2021

That's a good idea!! Also shall I just send the code? Like can you manually install the packages, because the problem is occurring as different people are using yarn or npm to install packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 Issues for GirlSript Summer of Code Level3 New feature, Major Bug fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend for contact us form
4 participants