Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU performance level/mode pinning #109

Closed
wants to merge 17 commits into from
Closed

GPU performance level/mode pinning #109

wants to merge 17 commits into from

Conversation

mdiluz
Copy link
Contributor

@mdiluz mdiluz commented Mar 8, 2019

Applies on top of #108.

  • Allows controlling GPUPowerMizerMode on Nvidia (nv_powermizer_mode in config)
  • Allows controlling the power_dpm_force_performance_level file on AMD (amd_performance_level in config)
  • Removes non-functioning amd_core_clock_percentage and amd_mem_clock_percentage, fully featured amd overclock tweaks can come later
  • Implements properly getting the GPU state on AMD and Nvidia, so that GameMode always tries to return the state back to the way it found it

mdiluz added 16 commits March 7, 2019 17:51
@mdiluz
Use the actual dbus error when failing in the client
142edc7 
	This helps greatly when identifying what went wrong
@mdiluz
Try waiting for the reaper thread at the start of tests if needed
9d8b921
@mdiluz
Run the custom start scripts to after the other optimisations
d37a6d7 
	This ensures the other featues are applied first, and the scripts can react if needed to those settings
@mdiluz
Refactor out script execution
dadfdf8
@mdiluz
Use run_external_process for the script execution
e0b646d 
	This protects the main process against script exection and allows more detailed error handling
@mdiluz
Implement a timeout in run_external_process
0e85932
@mdiluz
Combine the two run_external_process functions so they both have the …
ffc194b 
…same timeout protection
@mdiluz
Add the timout to the call signature of run_external_process
33c019c
@mdiluz
Add "script_timeout" config value to control if a user wants to exten…
cca219f 
…d the script timeout before kill value
@mdiluz
Add the output to the log for external processes that have failed
a143c03
@mdiluz
set the default gov not the desired gov in tests
f40438d
@mdiluz
Extend the sleep for the child gamemode in tests
89d55fc
@mdiluz
Rename the core and mem stats to nv_ prefix
70a165c 
	These will be NV only going forward, as AMD needs a different chunk of work
@mdiluz
Change AMD overclocking to simply be setting the power_dpm_force_perf…
b43cc83 
…ormance_level file for now

	This covers the MVP for now, and simply allows pinning the power level to "high"

	Full overclocking set up is somewhat more complicated, and it'll be better to implement that at the same time as the same for Nvidia, where we're currently only really setting the top end power level
@mdiluz
Implement nv_powermizer_mode option to allow setting the Nvidia power…
d1d6273 
…mizer mode
@mdiluz
Allow nv_perl_level and nv_powermizer_mode to be set independently
241554e
@mdiluz mdiluz changed the title Gpu powerlevel pinning GPU performance level/mode pinning Mar 8, 2019
@OlliC
Copy link
Contributor

OlliC commented Mar 9, 2019

Does this solve #45 ?

@mdiluz
Copy link
Contributor Author

mdiluz commented Mar 9, 2019

I think that would have been this: 949bf29

@aejsmith
Copy link
Contributor

I've merged this manually since it includes the commits from #108.

@mdiluz
Copy link
Contributor Author

mdiluz commented Mar 10, 2019

Cheers :)

@mdiluz mdiluz closed this Mar 10, 2019
@mdiluz mdiluz deleted the gpu-powerlevel-pinning branch May 25, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdiluz @OlliC @aejsmith