Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow fetch file refactoring #102

Merged
merged 16 commits into from
Jun 20, 2023
Merged

Conversation

Melisa-Zorraindo
Copy link
Collaborator

@Melisa-Zorraindo Melisa-Zorraindo commented Jun 15, 2023

I made some reusable functions:

  • checkForEmojis: check if a string is an emoji
  • createFrontmatterTable: generates an html table with the frontmatter from the file if there is any
  • displayDiff: displays the generated diff file
  • displayPreview: displays the file with the most recent changes
  • generateDiff: creates a new diff component
  • styleCallouts: adds styling to the callouts

The frontmatter is now displayed as an HTML table.

The next step would be to enhance the fetch function to allow fetching any remote file. Currently, it has a hardcoded address - but I'll make a new PR for this feature.

Copy link
Owner

@Fermain Fermain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Melissa!

@Melisa-Zorraindo Melisa-Zorraindo merged commit 3e30ea5 into master Jun 20, 2023
@Melisa-Zorraindo Melisa-Zorraindo deleted the flow-fetch-file-refactoring branch June 20, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants