Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from closed source development #106

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

Fermain
Copy link
Owner

@Fermain Fermain commented Jul 10, 2023

These are changes that I made during the process of getting a Mollify instance ready for production. My changes have been squashed into a single commit. This makes this a particularly unpleasant PR to review and this would fail the workflow CA.

There are a lot of whitespace changes in here, that's because I set a global fascist style 2-space tab rule. This is for the greater good.

Fun new features include a markdown linter, which is now built into the lint and lint:fix commands.

@Fermain Fermain requested review from Anclagen and pretzL July 10, 2023 18:30
Copy link
Collaborator

@Anclagen Anclagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Some minor thing I have noticed on the content;

  • Some of the images on the hosted content come out as text eg: ![Unique image](../images/desgn-1/Contentmanagement-5.jpeg)
  • Need some more callout styling on 📚 and 🎥
  • Tags page doesn't seem to be functioning correctly with the hosted content but works find in development with test content.

@Fermain
Copy link
Owner Author

Fermain commented Jul 11, 2023

  • Some of the images on the hosted content come out as text eg: ![Unique image](../images/desgn-1/Contentmanagement-5.jpeg)

I am doing image migration today. First prize is colocating images in the route with their page, so all references will just be image-name.jpg instead of a full path.

Need some more callout styling on 📚 and 🎥

Agreed

Tags page doesn't seem to be functioning correctly with the hosted content but works find in development with test content.

Will check it out today.

Thanks for your feedback

@Fermain Fermain merged commit 53822c8 into Fermain:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants