-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update topology example #1035
base: master
Are you sure you want to change the base?
Update topology example #1035
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 93.60% 93.61% +0.01%
==========================================
Files 39 39
Lines 5883 5893 +10
==========================================
+ Hits 5507 5517 +10
Misses 376 376 ☔ View full report in Codecov by Sentry. |
Not sure what is going on with the doc build...
|
I had the exact same issue a while ago with the docs with Julia 10.4. It turned out that the dependency (FerriteMeshParser) was only partially downloaded. Found this by manually inspecting the depot folder (.julia/package/FerriteMeshParser). I could come up with a reproducer and eventually forgot about it. |
Perhaps? (Not the best error message in that case, trying to - git-tree-sha1 = "5c0ffe1dff8cb7112de075f1b1cb32191675fcba"
+ path = "dev/BlockArrays" |
Ah, thanks, that was not intended to commit. Weird that Pkg didn't complain about that indeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor suggestions.
Are there any measureable improvements when not creating many Vectors{Vectors}
here as well? In that case, perhaps a small comment would be nice for users to understand why we use VectorOfArrays
?
# the function call will return an empty object. In that case we use the dictionary to instead find the opposite | ||
# face, as discussed in the introduction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above needs to reflect that a tuple is used I think?
Co-authored-by: Knut Andreas Meyer <knutam@gmail.com>
Fixes #1031