-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove export of ScalarValues and VectorValues #416
Conversation
Removed in #404. Docs look more ugly now, it was nice to be able to reference both |
Not sure why "curl" fails, the new test passes when I run |
We could document the Not sure if I like writing out |
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 91.05% 91.06%
=======================================
Files 22 22
Lines 2897 2898 +1
=======================================
+ Hits 2638 2639 +1
Misses 259 259
Continue to review full report at Codecov.
|
Could one write e.g "where |
Seems not so nice to me to hide it away like that. Perhaps just an introductory section at the top of https://ferrite-fem.github.io/Ferrite.jl/stable/reference/fevalues/ which explains that there are |
Yes, that would be even better! |
No need to do it in this PR, the PR is after all about removing the export that I forgot to remove in #404 . I can draft something for the |
* Remove export of undefined datatypes ScalarValues and VectorValues * Remove mentioning of undefined datatypes in docstrings * Add test to ensure all exported symbols are defined * Fix test to check qualified exported symbols * Update test/runtests.jl * Remove changes to docs, to be updated in other PR Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
ScalarValues
andVectorValues
are exported but don't seem to be defined.I also added a test to check that no symbols are exported that haven't been defined. Not sure where to put this test though...