Arbitrary evaluation in points #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimauth
reviewed
Feb 22, 2022
koehlerson
reviewed
Feb 22, 2022
fredrikekre
changed the title
fredrikekre
force-pushed
the
fe/point_eval
branch
from
b9e3097 to
c35918e
Compare
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 91.13% 91.30% +0.16%
==========================================
Files 22 22
Lines 3181 3243 +62
==========================================
+ Hits 2899 2961 +62
Misses 282 282
Continue to review full report at Codecov.
|
fredrikekre
force-pushed
the
fe/point_eval
branch
from
c35918e to
a513596
Compare
kimauth
reviewed
Feb 23, 2022
fredrikekre
changed the title
fredrikekre
force-pushed
the
fe/point_eval
branch
2 times, most recently
from
bdbae00 to
2c0f472
Compare
This commit introduces a number of new things that can be used together
with the PointEvalHandler:
- PointScalarValues and PointVectorValues: These are similar to
CellValues, but have only one, updateable, "quadrature point".
- PointIterator: Iterator for iterating over the points in a
PointEvalHandler.
- PointLocation: Element of a PointIterator.
The intended workflow is as follows:
ph = PointEvalHandler(grid, points)
pv = PointScalarValues(cellvalues)
for p in PointIterator(ph)
p === nothing && continue # This point was not found
reinit!(pv, p) # reinit! with the new point
function_gradient(cv, uh) # Compute stuff
end
Other changes:
- Grid: Fix cellnodes! and cellcoords! for grids with mixed element types.
- PointEvalHandler: Rename the old PointScalarValues to
PointScalarValuesInternal. These are (still) used internally in
get_point_values, and are a nice optimization of PointScalarValues
since they avoid recomputation of both i) dNdξ, and ii) dNdx.
- Docs: update doc build dependencies.
fredrikekre
force-pushed
the
fe/point_eval
branch
from
2c0f472 to
275b0cf
Compare
koehlerson
pushed a commit
that referenced
this pull request
Apr 22, 2022
This commit introduces a number of new things that can be used together
with the PointEvalHandler:
- PointScalarValues and PointVectorValues: These are similar to
CellValues, but have only one, updateable, "quadrature point".
- PointIterator: Iterator for iterating over the points in a
PointEvalHandler.
- PointLocation: Element of a PointIterator.
The intended workflow is as follows:
ph = PointEvalHandler(grid, points)
pv = PointScalarValues(cellvalues)
for p in PointIterator(ph)
p === nothing && continue # This point was not found
reinit!(pv, p) # reinit! with the new point
function_gradient(cv, uh) # Compute stuff
end
Other changes:
- Grid: Fix cellnodes! and cellcoords! for grids with mixed element types.
- PointEvalHandler: Rename the old PointScalarValues to
PointScalarValuesInternal. These are (still) used internally in
get_point_values, and are a nice optimization of PointScalarValues
since they avoid recomputation of both i) dNdξ, and ii) dNdx.
- Docs: update doc build dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.