More complete support for periodic boundary conditions #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 91.38% 91.55% +0.17%
==========================================
Files 22 22
Lines 3411 3542 +131
==========================================
+ Hits 3117 3243 +126
- Misses 294 299 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This patch adds better support for specifying periodic boundary conditions. In particular, collect_periodic_faces(!) is added, which, for given input mirror and image sets computes the matching face. The result can be passed directly to the PeriodicDirichlet constructor. The existing limitation about full periodicity (i.e. all directions) is removed.
fredrikekre
force-pushed
the
fe/collect-periodic
branch
from
71986fe to
8afaa14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds better support for specifying periodic boundary conditions. In particular,
collect_periodic_faces(!)is added, which, for given input mirror and image sets computes the matching face. The result can be passed directly to thePeriodicDirichletconstructor. The existing limitation about full periodicity (i.e. all directions) is removed.