Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic constraints: support dof-rotation #496

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

fredrikekre
Copy link
Member

No description provided.

This patch adds the ability to rotate dof-vectors for periodic
constraints. This is done by passing a rotation matrix to the
PeriodicDirichlet constructor.
@fredrikekre fredrikekre force-pushed the fe/around-the-world-around-the-world branch from 193d589 to fb9c982 Compare September 29, 2022 16:14
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Base: 91.91% // Head: 91.99% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (aa85de9) compared to base (fe7dbf6).
Patch coverage: 91.17% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   91.91%   91.99%   +0.08%     
==========================================
  Files          22       22              
  Lines        3647     3672      +25     
==========================================
+ Hits         3352     3378      +26     
+ Misses        295      294       -1     
Impacted Files Coverage Δ
src/Dofs/ConstraintHandler.jl 92.98% <91.17%> (-0.16%) ⬇️
src/Grid/grid.jl 86.94% <0.00%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lijas lijas closed this Sep 29, 2022
@KristofferC
Copy link
Collaborator

Elias says nope.

@lijas
Copy link
Collaborator

lijas commented Sep 29, 2022

Lol woops, must have been a "butt close"

@lijas lijas reopened this Sep 29, 2022
@fredrikekre fredrikekre force-pushed the fe/around-the-world-around-the-world branch 3 times, most recently from 6609b6c to aa85de9 Compare October 3, 2022 12:52
This patch adds a new example to the documentation. The main new
contribution of this example is that i) it shows how to use Gmsh for
meshing and ii) it shows how to apply periodic boundary conditions that
are rotated.
@fredrikekre fredrikekre force-pushed the fe/around-the-world-around-the-world branch from aa85de9 to c01bb2c Compare October 3, 2022 13:43
@fredrikekre fredrikekre merged commit f02f888 into master Oct 3, 2022
@fredrikekre fredrikekre deleted the fe/around-the-world-around-the-world branch October 3, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants