Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded elements showcase: Gray-Scott model on a sphere #715

Merged
merged 31 commits into from
May 31, 2024

Conversation

termi-official
Copy link
Member

@termi-official termi-official commented May 19, 2023

This needs quite a bit of polishing, but it is at least a functional example.

reactive-surface

TODO

  • Parameter passing for diffusivity
  • Documentation
  • Faster solver
  • Cleaner assembly code
  • Update FerriteGmsh to allow parsing of embedded meshes Use FerriteGmsh to generate the mesh on the fly

@termi-official termi-official mentioned this pull request May 19, 2023
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (cf97ee5) to head (5ab82f2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          36       36           
  Lines        5438     5438           
=======================================
  Hits         5095     5095           
  Misses        343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@termi-official
Copy link
Member Author

termi-official commented Jul 4, 2023

Little hack to get the mesh

try
  togrid("sphere.msh")
catch
end
nodes = tonodes();
elements, gmsh_elementidx = toelements(2);

@termi-official termi-official marked this pull request as ready for review July 4, 2023 18:10
@termi-official
Copy link
Member Author

If we want to include this in the next release, then this is as good as it might get, because we need the next release first to make the FerriteGmsh update (due to the breaking changes).

@termi-official termi-official added the awaiting review PR is finished from the authors POV, waiting for feedback label Jan 31, 2024
@termi-official
Copy link
Member Author

Ready again @fredrikekre

termi-official and others added 2 commits May 30, 2024 16:40
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Since the main reason for this tutorial to exist is to show embedding I think it could be highlighted a bit more. However, since Ferrite is now pretty general there is really nothing extra you need to do to make embedding work :D Perhaps just add a remark somewhere that highlights that we use 2D elements embedded in 3D space?

docs/src/literate-tutorials/reactive_surface.jl Outdated Show resolved Hide resolved
docs/src/literate-tutorials/reactive_surface.jl Outdated Show resolved Hide resolved
docs/src/literate-tutorials/reactive_surface.jl Outdated Show resolved Hide resolved
@termi-official
Copy link
Member Author

termi-official commented May 31, 2024

Very nice. Since the main reason for this tutorial to exist is to show embedding I think it could be highlighted a bit more. However, since Ferrite is now pretty general there is really nothing extra you need to do to make embedding work :D

I also struggled a bit with this one. Maybe I should add a note to the devdocs for users who might be interested in the internals?

Perhaps just add a remark somewhere that highlights that we use 2D elements embedded in 3D space?

Will do.

@fredrikekre fredrikekre merged commit 60aacb1 into master May 31, 2024
11 checks passed
@fredrikekre fredrikekre deleted the do/reactive-surface branch May 31, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR is finished from the authors POV, waiting for feedback docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants