-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded elements showcase: Gray-Scott model on a sphere #715
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 36 36
Lines 5438 5438
=======================================
Hits 5095 5095
Misses 343 343 ☔ View full report in Codecov by Sentry. |
Little hack to get the mesh
|
If we want to include this in the next release, then this is as good as it might get, because we need the next release first to make the FerriteGmsh update (due to the breaking changes). |
Ready again @fredrikekre |
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Since the main reason for this tutorial to exist is to show embedding I think it could be highlighted a bit more. However, since Ferrite is now pretty general there is really nothing extra you need to do to make embedding work :D Perhaps just add a remark somewhere that highlights that we use 2D elements embedded in 3D space?
I also struggled a bit with this one. Maybe I should add a note to the devdocs for users who might be interested in the internals?
Will do. |
This needs quite a bit of polishing, but it is at least a functional example.
TODO
Parameter passing for diffusivityFaster solverUpdate FerriteGmsh to allow parsing of embedded meshesUse FerriteGmsh to generate the mesh on the fly