Replace shape_value etc for interpolations with reference_shape_value
#997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue` This patch is a follow up to #721 and replaces `shape_value`, `shape_gradient` etc for interpolations, which return evaluations in the reference domain, with new functions `reference_shape_value`, `reference_shape_gradient`, etc. The new functions are public but not exported. Separating these functions make it possible to support `reference_shape_value` etc for `CellValues` too in the future.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 38 38
Lines 5723 5723
=======================================
Hits 5362 5362
Misses 361 361 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 31, 2024
KnutAM
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow up to #721 and replaces
shape_value,shape_gradientetc for interpolations, which return evaluations in the reference domain, with new functionsreference_shape_value,reference_shape_gradient, etc. The new functions are public but not exported.Separating these functions make it possible to support
reference_shape_valueetc forCellValuestoo in the future.