-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2D flux field visualization #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, I think it would be nice to support vector valued fields in 2D for this.
Can you elaborate on https://github.com/Ferrite-FEM/FerriteViz.jl/blob/master/src/utils.jl#L292-L297 ?
The problem mentioned in https://github.com/Ferrite-FEM/FerriteViz.jl/blob/master/src/utils.jl#L292-L297 is that for volumetric entities we need an interpolation on entities with dimension 2 (for the most common problems). Now, L2 spaces have support on the local portion of a face, but not on the actual shared face. However, the current implementation just extract the faces from the provided interpolation to build the face triangles - which is an empty set for L2 spaces. |
…ks for flux on quads, however, triangles don't work
Apart from test coverage for Edit: 3D is future work when clip planes are implemented. |
How does the docs example with 3D plasticity work then? :D |
Derp. |
take the incompressible elasticity, there we can visualize both, stresses and strains, or alternatively heat example with the heat flux (so negative gradient with some constant) to show off how to get from gradient to flux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few suggestions
Okay, I think now only the next Ferrite release is missing (because of the L2 fix you pushed @koehlerson ). |
builds locally with |
we can also think about having |
I would vote for sticking with the safe route, manually upgrading at each release to capture regressions. |
Gradient field converges for the heat problem towards the analytical gradient in 2d julia> maximum(u_grad) - π/2
0.0072785284134289086 and 3d julia> maximum(u_grad) - π/2
0.01160556577741545 |
457929b
to
f052cb4
Compare
I think we could add a |
Before we start introducing more and more hotfixes, I think we should focus on reorganizing the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Co-authored-by: Maximilian Köhler <maximilian.koehler@ruhr-uni-bochum.de>
Correctness of shear component computation has been roughly tested via some crappy simple shear
|
CI failed because it turns out that Tensors.jl gradients are the outermost indices, but access to a Vec (case: scalar problem) with two indices does not work. :) Should be fine now. |
Stepped up the game and checked analytically the gradient field. It converges. :)