Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay not working after alt-tabbing / playing steamworks #49

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

l1m0n3
Copy link
Contributor

@l1m0n3 l1m0n3 commented Oct 20, 2024

Tested on DirectX12 enabled + fullscreen.

When alt-tabbing, d3d12_deinitialize_imgui which is called by d3d_resize_buffers_hook gets called.
In d3d12_deinitialize_imgui, it nullifies m_d3d12_command_queue and it always be nullptr after that.
In Present hook, it checks if command queue is valid and also steamworks is not active.
If checks failed, it will return early but never assign back to m_is_inside_present = false.
This will cause an issue as title says.

This PR fixes the issue by just keeping command queue when deinitializing and assigning the flag back properly.

I know nothing about DirectX or rendering stuff, so sorry if this is not a proper fix.

@Fexty12573
Copy link
Owner

Thank you for the PR! Looks good, I will merge it once the builds complete

@Fexty12573 Fexty12573 merged commit 84d78c2 into Fexty12573:master Nov 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants