Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by primary key in descending order #218

Closed
novoj opened this issue Aug 10, 2023 · 0 comments · Fixed by #360
Closed

Sort by primary key in descending order #218

novoj opened this issue Aug 10, 2023 · 0 comments · Fixed by #360
Assignees
@novoj
Labels
enhancement New feature or request
Milestone
Alpha

Comments

@novoj
Copy link
Collaborator

novoj commented Aug 10, 2023

The implicit ordering is ASC by primary key, but we have discovered that we lack the possibility to order by PK in descending fashion. Although this ordering is not widely used, we should support it. Because we have orderign constraints entityPrimaryKeyInFilter and entityPrimaryKeyExact we should provide new constraint to be used like that:

query(
   orderBy(
      entityPrimaryKey(DESC)
   )
)

And this would produce output sorted by PK in descending order.
@novoj novoj added the enhancement New feature or request label Aug 10, 2023
@novoj novoj added this to the Alpha milestone Aug 10, 2023
@novoj novoj self-assigned this Aug 10, 2023
novoj added a commit that referenced this issue Dec 5, 2023
@novoj
feat(#218): sort by primary key in descending order
9e65a86 
The implicit ordering is ASC by primary key, but we have discovered that we lack the possibility to order by PK in descending fashion. Although this ordering is not widely used, we should support it. Because we have orderign constraints `entityPrimaryKeyInFilter` and `entityPrimaryKeyExact` we should provide new constraint to be used like that:

```
query(
   orderBy(
      entityPrimaryKey(DESC)
   )
)
```

And this would produce output sorted by PK in descending order.
@novoj novoj linked a pull request Dec 5, 2023 that will close this issue
#218 sort by primary key in descending order #360
Merged
@novoj novoj mentioned this issue Dec 5, 2023
Closed
@novoj novoj closed this as completed in #360 Dec 5, 2023
novoj added a commit that referenced this issue Dec 5, 2023
@novoj
Merge pull request #360 from FgForrest/218-sort-by-primary-key-in-des…
f9fd30a 
…cending-order

#218 sort by primary key in descending order
lukashornych added a commit that referenced this issue Dec 5, 2023
@lukashornych
style(#218): evitaql primarykeynatural grammar consistency
5766556
lukashornych added a commit that referenced this issue Dec 5, 2023
@lukashornych
test(#218): more pk natural parser tests
62455da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novoj novoj

Labels
enhancement New feature or request
Projects
None yet
Milestone
Alpha
Development

Successfully merging a pull request may close this issue.

#218 sort by primary key in descending order FgForrest/evitaDB
1 participant
@novoj