-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System / gRPC API should provide information about evitaDB server version #406
Comments
At this point I suggest to create an endpoint in the system API that would return simplified info about the evitaDB instance like we've already talked about. Because we already need server name and evitaDB version and evitaLab would benefit from list of running APIs with their URLs (even though this could be separate API in the lab API): {
"serverName": "evitadb",
"version": "1.0.0",
"apis": [
"graphql": {
"url": "https://localhost:5555/gql"
}
]
} |
We need to consider that this endpoint will sometimes need to be behind authentication in the future. The server must not return its version to an unauthenticated client for security reasons. |
We could return differently rich objects based on authentication. E.g. for non-authenticated:
and for authenticated as I mentioned above. Yeah if would have different endpoints for these, would easily setup the auth. rules based on endpoint paths, but the REST API will definitely have to have some tools for enabling/disabling returned properties, which we could maybe reuse here and have single endpoint. |
…B server version We need to provide sever version in gRPC evitaLab API, so then the clients can visualize it and reason about it. We should also provide a method to detect the client version. Java client should log an error/warning if its minor version differs from the server version, as it might signal compatibility problems. Implemented the gRPC part and the compatibility check.
gRPC implementation and compatibility check in client is done. Tomorrow I'll implement the system endpoint. |
System status endpoint implemented example resonse:
|
…B server version We need to provide sever version in gRPC evitaLab API, so then the clients can visualize it and reason about it. We should also provide a method to detect the client version. Java client should log an error/warning if its minor version differs from the server version, as it might signal compatibility problems. Implemented system endpoint.
…vide-information-about-evitadb-server-version feat(#406): System / gRPC API should provide information about evitaDB server version
…B server version Support for accessing client version via API.
We need to provide sever version in gRPC evitaLab API, so then the clients can visualize it and reason about it. We should also provide a method to detect the client version. Java client should log an error/warning if its minor version differs from the server version, as it might signal compatibility problems.
The text was updated successfully, but these errors were encountered: