Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preconfigured connection in embedded evitaLab are sometimes not loaded #737

Closed
lukashornych opened this issue Nov 7, 2024 · 3 comments · Fixed by #738
Closed

Preconfigured connection in embedded evitaLab are sometimes not loaded #737

lukashornych opened this issue Nov 7, 2024 · 3 comments · Fixed by #738
Assignees
Labels
bug Something isn't working

Comments

@lukashornych
Copy link
Collaborator

Preconfigured connections are passed to embedded evitaLab through cookies. After last update that should have fixed an issue with cookies not being overwritten correctly, loading evitaLab with old data, the current solution seems to have opposite problem. Sometimes data are not present at all.

It happens during first load of new browser tab. After page reload, data are loaded correctly.

@lukashornych lukashornych self-assigned this Nov 7, 2024
@lukashornych lukashornych added the bug Something isn't working label Nov 7, 2024
@lukashornych
Copy link
Collaborator Author

The solution I settled at is to pass the data (server name, pre. connections, ...) to evitaLab through URL query params through redirect. This seems to be working quite well and it should hopefully solved both problems (old data and no data).

Support in evitaLab for this is implemented in lukashornych/evitalab#227

lukashornych added a commit that referenced this issue Nov 7, 2024
…n-embedded-evitalab-are-sometimes-not-loaded

fix(#737): passing data to embedded evitaLab through unreliable cookies
@lukashornych lukashornych reopened this Nov 8, 2024
@lukashornych
Copy link
Collaborator Author

lukashornych commented Nov 8, 2024

There seems to be issues in some browsers (Firefox only?) where when navigated link to evitaLab with demo snippet from evitaDB documentation site, it doesn't do a reload so data are not passed. Maybe it has something to do with caches? But subsequent refresh of that page does the server reload correctly.

Maybe we need to send something like

Cache-Control: no-store, no-cache, must-revalidate

lukashornych added a commit that referenced this issue Nov 8, 2024
…n-embedded-evitalab-are-sometimes-not-loaded

 fix(#737): proper cache control for evitaLab sources
@lukashornych
Copy link
Collaborator Author

Caching on Index.html is now disabled to always refresh evitaLab data. Assets use immutable caching for long time now as they are versioned in new evitaLab version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant