[sc-21418] adds retry on network failures #1
Conversation
|
This pull request has been linked to Shortcut Story #21418: Retry network failures on vercel polling. |
| @@ -1,19 +1,13 @@ | |||
| { | |||
| "systemParams": "darwin-x64-108", | |||
| "systemParams": "darwin-arm64-108", | |||
There was a problem hiding this comment.
Any insight into this change @namoscato ? I'm actually not super familiar with yarn.
There was a problem hiding this comment.
I'm not intimately familiar with it either but don't think we have control over it given we're running this on M1s. It looks like this changed recently to x64 in UnlyEd#89, so let's roll with this proposal.
There was a problem hiding this comment.
Curious.... how do we mean "we're running this on M1s"? Won't this be invoked via x86_64 architectures in github actions?
Admittedly, I'm not familiar with yarn so I may be misunderstanding what this represents.
There was a problem hiding this comment.
Oh sorry, to be clear – we ran the yarn add command on an M1 to install this new package locally, which resulted in this .yarn-integrity change, which is committed to version control.
Reinstall new package on: $ yarn --version 1.22.19 $ rm -rf node_modules/ $ git checkout main -- yarn.lock $ yarn add @adobe/node-fetch-retry
| @@ -1,19 +1,13 @@ | |||
| { | |||
| "systemParams": "darwin-x64-108", | |||
| "systemParams": "darwin-arm64-108", | |||
There was a problem hiding this comment.
I'm not intimately familiar with it either but don't think we have control over it given we're running this on M1s. It looks like this changed recently to x64 in UnlyEd#89, so let's roll with this proposal.
Adds retry capabilities for network failures