Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-43991] update pipeline imports #40

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

nrutman
Copy link
Contributor

@nrutman nrutman commented Oct 8, 2024

Updates imports in the package

  • Adds PipelineRollbackError to the main error/index.ts file
  • Moves builds to tsup (tsup bundles the library into a single file rather than multiple files…which removes the need for global imports that causes webpack to 🤮)

Copy link

@mmhand123 mmhand123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired on it a bit live ! Also tested locally with npm link and verified lambda starts up. Looks great. Think we should look at standardizing on this for all our npm packages probably.

@nrutman nrutman merged commit 7b6f58d into main Oct 8, 2024
1 check passed
@nrutman nrutman deleted the naterutman/sc-43991/update-pipeline-imports branch October 8, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants