[SC-58776] Publish Pipeline package to NPM and Github #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twhitbeck
reviewed
Jun 23, 2025
twhitbeck
reviewed
Jun 23, 2025
| with: | ||
| node-version-file: ".nvmrc" | ||
| cache: "npm" | ||
| registry-url: "https://npm.pkg.github.com" |
There was a problem hiding this comment.
I wonder if we need to specify scope here, too?
Contributor
Author
There was a problem hiding this comment.
I was taking my inspiration from the publish jobs in the js-common repo...for example:
https://github.com/Fieldguide/js-common/blob/main/.github/workflows/publish-files.yaml
...and those don't use a scope when publishing to GitHub.
Contributor
Author
|
For other reviewers…some conversation for context was happening in this Slack thread: https://fieldguideco.slack.com/archives/C018HLNEFF1/p1750707625744909 |
twhitbeck
approved these changes
Jun 23, 2025
nrutman
deleted the
naterutman/sc-58776/publish-pipeline-package-to-github
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Our internal packages configure the
@fieldguidenamespace to pull from Github for packages like those in https://github.com/fieldguide/js-common.This causes problems when we also want to access public packages under this namespace. It leads to strange situations like this Action Server NPM configuration.
By publishing the Pipeline package to both NPM and Github Packages, it should allow other Fieldguide repos (e.g. Action Server) to successfully pull the Pipeline package from the Github repository instead of the NPM repository.