Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UXIT-2349] FFDW Add Author Bio #1277

Merged
merged 12 commits into from
Mar 20, 2025
Merged

[UXIT-2349] FFDW Add Author Bio #1277

merged 12 commits into from
Mar 20, 2025

Conversation

barbaraperic
Copy link
Collaborator

@barbaraperic barbaraperic commented Mar 18, 2025 •
edited
Loading

📝 Description

This PR includes a new AuthorsBio component and refactor of formatAuthors which is now a shared function.

  • Type: New feature / Refactor

NOTE: an edge case we might wanna consider - if only one bio is present, it will still show the names of the both authors in the title (see screenshot below).

Not sure if we want it that way? Or you think it's fine? Currently we are show AuthorsBio if at least one bio is present. Quick fix could be if we change the title to something like About the author/s.... but also happy to refactor to show only the names of the authors to have bios. Let me know thoughts 😊

Screenshot 2025-03-18 at 17 11 25

📸 Screenshots

Screenshot 2025-03-18 at 16 11 27 Screenshot 2025-03-18 at 16 11 35 Screenshot 2025-03-18 at 16 11 55

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ffdweb-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 10:12am
filecoin-foundation-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 10:12am

@notion-workspace Notion Workspace
Copy link

[FFDW] Digest/[slug] Include author bio section

@barbaraperic barbaraperic self-assigned this Mar 18, 2025
@barbaraperic barbaraperic marked this pull request as ready for review March 18, 2025 17:23
@mirhamasala
Copy link
Collaborator

mirhamasala commented Mar 18, 2025 •
edited
Loading

@barbaraperic

Not sure if we want it that way? Or you think it's fine? Currently we are show AuthorsBio if at least one bio is present. Quick fix could be if we change the title to something like About the author/s.... but also happy to refactor to show only the names of the authors to have bios. Let me know thoughts 😊

We need to make the bio field required for FFDW. Also, for the article using a combined bio, we should update it to have two separate bios. Please check with Jordan for the copy if needed. For the layout, we can simply duplicate the design of a single bio section for rendering. 🙏🏼

@barbaraperic
Copy link
Collaborator Author

barbaraperic commented Mar 19, 2025 •
edited
Loading

@barbaraperic

Not sure if we want it that way? Or you think it's fine? Currently we are show AuthorsBio if at least one bio is present. Quick fix could be if we change the title to something like About the author/s.... but also happy to refactor to show only the names of the authors to have bios. Let me know thoughts 😊

We need to make the bio field required for FFDW. Also, for the article using a combined bio, we should update it to have two separate bios. Please check with Jordan for the copy if needed. For the layout, we can simply duplicate the design of a single bio section for rendering. 🙏🏼

@mirhamasala like this?

Screenshot 2025-03-19 at 11 57 29

mirhamasala
mirhamasala approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@mirhamasala mirhamasala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit CR. But this is excellent - Thank you for your patience. ❤️

@barbaraperic barbaraperic merged commit 4ac9fee into main Mar 20, 2025
8 checks passed
@barbaraperic barbaraperic deleted the bp/ffdw-author-bio branch March 20, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirhamasala mirhamasala mirhamasala approved these changes

Assignees

@barbaraperic barbaraperic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barbaraperic @mirhamasala