Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFDW][UXIT-2420] Fixup Metadata #1278

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mirhamasala
Copy link
Collaborator

📝 Description

Please include a summary of the changes. Provide context and motivation for the change, and describe what problem it solves.

  • Type: Bug fix / New feature / Documentation / Refactor

🛠️ Key Changes

  • [Change 1 - Brief description]
  • [Change 2 - Brief description]
  • ...

📌 To-Do Before Merging

  • [Task 1 - Brief description]
  • [Task 2 - Brief description]
  • ...

🧪 How to Test

  • Setup: [Setup details]
  • Steps to Test:
    1. [Step 1 - Brief description]
    2. [Step 2 - Brief description]
    3. ...
  • Expected Results: [Outcome]
  • Additional Notes: [Additional info]

📸 Screenshots

Attach if there are UI changes.

🔖 Resources

Feel free to share any references to documentation, libraries, blog posts, or other resources that you consulted or used during the implementation of the changes.

  • [Resource 1]
  • [Resource 2]
  • ...

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ffdweb-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 9:05am
filecoin-foundation-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 9:05am

@mirhamasala
Copy link
Collaborator Author

mirhamasala commented Mar 19, 2025

@CharlyMartin - The metadata isn't being pulled as expected.

These should be using the template below but they don't.

export const metadata: Metadata = {
  title: {
    template: `${ORGANIZATION_NAME_SHORT} | %s`,
    default: ORGANIZATION_NAME,
  },
  metadataBase: new URL(BASE_URL),
}

@barbaraperic - This is the PR that you should use for [UXIT-2411] - @CharlyMartin will ping you for review when done. 🙏🏼

@mirhamasala mirhamasala changed the title [FFDW] Fixup Metadata [FFDW][UXIT-2420] Fixup Metadata Mar 19, 2025
Copy link

[FFDW] Fixup Metadata

@CharlyMartin CharlyMartin self-assigned this Mar 19, 2025
@CharlyMartin
Copy link
Collaborator

CharlyMartin commented Mar 19, 2025

@mirhamasala Apparently https://www.opengraph.xyz is not reading the website's head correctly.

On https://ffdweb.org/ (and all pages that use the default template) I see FFDW | ...

https://vercel.com/filecoin-foundations-projects/ffdweb-site/mnaCSJ1aSRvegy25MsFshiTbcaXK/og


CleanShot 2025-03-19 at 10 03 00@2x


<head>
  <title>FFDW | Rebuilding the Internet for Good</title>
  <meta
    name="description"
    content="Filecoin Foundation for the Decentralized Web is a nonprofit organization committed to preserving humanity’s most important information by funding the development of open-source tools"
  />
  <link rel="canonical" href="https://ffdweb.org" />
  <meta property="og:title" content="Rebuilding the Internet for Good" />
  <meta
    property="og:description"
    content="Filecoin Foundation for the Decentralized Web is a nonprofit organization committed to preserving humanity’s most important information by funding the development of open-source tools"
  />
  <meta property="og:url" content="https://ffdweb.org" />
  <meta
    property="og:site_name"
    content="Filecoin Foundation for the Decentralized Web"
  />
  <meta
    property="og:image"
    content="https://ffdweb.org/_next/static/media/homepage.5a7d1b6b.webp"
  />
  <meta property="og:type" content="website" />
  <meta name="twitter:card" content="summary" />
  <meta name="twitter:site" content="@ffdweb" />
  <meta name="twitter:creator" content="@ffdweb" />
  <meta name="twitter:title" content="Rebuilding the Internet for Good" />
  <meta
    name="twitter:description"
    content="Filecoin Foundation for the Decentralized Web is a nonprofit organization committed to preserving humanity’s most important information by funding the development of open-source tools"
  />
  <meta
    name="twitter:image"
    content="https://ffdweb.org/_next/static/media/homepage.5a7d1b6b.webp"
  />
</head>

@mirhamasala
Copy link
Collaborator Author

mirhamasala commented Mar 19, 2025

@CharlyMartin - Odd. I wonder if it's cached or something like that. And not sure where Slack pulls the data from.. but yes, the HTML is correct.

Whenever you're ready, please feel free to close this PR. I moved the one little change to #1281.

CleanShot 2025-03-19 at 11 37 14@2x

@CharlyMartin
Copy link
Collaborator

CharlyMartin commented Mar 19, 2025

@mirhamasala Slack reads the open graph tags, and these don’t include the ${ORGANIZATION_NAME_SHORT} | %s prefix in the template, as shown in the HTML above. So Slack is behaving as expected.

My question is: Should og:title and og:description match the page’s meta title and description? I’m leaning towards yes.

In config.yml, we have &open_graph_config, but I didn’t find any Markdown instances where we set the open graph title and description. I suggest removing &open_graph_config and using the page’s meta info for open graph tags.

What do you think?


FYI, Claude's answer:

CleanShot 2025-03-19 at 16 00 46@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants