-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FFDW][UXIT-2420] Fixup Metadata #1278
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@CharlyMartin - The metadata isn't being pulled as expected.
These should be using the template below but they don't. export const metadata: Metadata = {
title: {
template: `${ORGANIZATION_NAME_SHORT} | %s`,
default: ORGANIZATION_NAME,
},
metadataBase: new URL(BASE_URL),
} @barbaraperic - This is the PR that you should use for [UXIT-2411] - @CharlyMartin will ping you for review when done. 🙏🏼 |
@mirhamasala Apparently https://www.opengraph.xyz is not reading the website's head correctly. On https://ffdweb.org/ (and all pages that use the default template) I see https://vercel.com/filecoin-foundations-projects/ffdweb-site/mnaCSJ1aSRvegy25MsFshiTbcaXK/og <head>
<title>FFDW | Rebuilding the Internet for Good</title>
<meta
name="description"
content="Filecoin Foundation for the Decentralized Web is a nonprofit organization committed to preserving humanity’s most important information by funding the development of open-source tools"
/>
<link rel="canonical" href="https://ffdweb.org" />
<meta property="og:title" content="Rebuilding the Internet for Good" />
<meta
property="og:description"
content="Filecoin Foundation for the Decentralized Web is a nonprofit organization committed to preserving humanity’s most important information by funding the development of open-source tools"
/>
<meta property="og:url" content="https://ffdweb.org" />
<meta
property="og:site_name"
content="Filecoin Foundation for the Decentralized Web"
/>
<meta
property="og:image"
content="https://ffdweb.org/_next/static/media/homepage.5a7d1b6b.webp"
/>
<meta property="og:type" content="website" />
<meta name="twitter:card" content="summary" />
<meta name="twitter:site" content="@ffdweb" />
<meta name="twitter:creator" content="@ffdweb" />
<meta name="twitter:title" content="Rebuilding the Internet for Good" />
<meta
name="twitter:description"
content="Filecoin Foundation for the Decentralized Web is a nonprofit organization committed to preserving humanity’s most important information by funding the development of open-source tools"
/>
<meta
name="twitter:image"
content="https://ffdweb.org/_next/static/media/homepage.5a7d1b6b.webp"
/>
</head> |
@CharlyMartin - Odd. I wonder if it's cached or something like that. And not sure where Slack pulls the data from.. but yes, the HTML is correct. Whenever you're ready, please feel free to close this PR. I moved the one little change to #1281. |
@mirhamasala Slack reads the open graph tags, and these don’t include the My question is: Should In What do you think? FYI, Claude's answer: |
📝 Description
Please include a summary of the changes. Provide context and motivation for the change, and describe what problem it solves.
🛠️ Key Changes
📌 To-Do Before Merging
🧪 How to Test
📸 Screenshots
Attach if there are UI changes.
🔖 Resources
Feel free to share any references to documentation, libraries, blog posts, or other resources that you consulted or used during the implementation of the changes.