.github/workflows: fix gotip tests on Windows
#623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default GitHub Actions Windows runners ship with several Go versions installed out of the box;
$env:PATHcontainsC:\hostedtoolcache\windows\go\1.21.13\x64\binby default.While
actions/setup-goinstalls Go 1.24.0 (stable) and prependsC:\hostedtoolcache\windows\go\1.24.0\x64\binto$env:PATHas expected, it's not being detected bymake.batas the preferred Go version for the bootstrap toolchain.Due to a bug1 in
src/make.bat, the last Go in$env:PATHwill take precedence over the first one, causingGOROOT_BOOTSTRAPto use the old Go 1.21.13 instead of 1.24.0.Since CL 606156, Go depends on 1.22.6 or later for bootstrap, and that's why the workflow is broken.
Footnotes
See https://go-review.googlesource.com/c/go/+/653535. ↩