set subject CN for client certificates #258
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many TLS servers and configurations perform client authentication using the subject CN in the client certificate. This change adds a subject CN to client certificates. Fixes FiloSottile#257.
|
Please approve and merge. This is very useful! |
|
Looks good to me! This would be very useful! 👍 |
|
See #257 (comment) |
|
I understand. As you said, it is easy enough for people to patch it themselves if required. Thanks! |
|
Thank you very much for this little tweak. It did exactly what I needed it to do today (for exactly the [postgres] reason that people have mentioned). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many TLS servers and configurations perform client authentication
using the subject CN in the client certificate. This change
adds a subject CN to client certificates.
Fixes #257.