Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOCUS dataset consistency review #474

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

aqu-erp
Copy link
Contributor

@aqu-erp aqu-erp commented May 29, 2024

Resolving #472

Acceptance

  • select a term to used to describe a FOCUS compliant dataset
  • defining term in glossary
  • maintain consistent usage of term across specification and changelog, etc.
  • add glossary anchors where needed
  • confirm convention for referring to a generic potentially noncompliant dataset from a provider

Proposed term and definition

FOCUS Dataset
A structured collection of cost and usage data that meets or exceeds the Basic compliance criteria of FOCUS.


Open Questions

When to retain use of billing data

  • When used in general context of FinOps data at large

Examples

Overview.md

FOCUS aims to establish a community-driven specification for consumption-based billing data.

Billing data generators: Infrastructure and services providers that bill based on consumption

Readme.md

The FOCUS spec will make it easier to merge multiple billing data sources together


Notes

  • Term replaces instances of -, billing data, and cost data in normative statements
  • Term does not refer to dataset supplied/created/provided by the spec
  • Term refers to dataset that is being described by normative statements
    • a dataset that meets certain compliance criteria

@aqu-erp aqu-erp requested a review from a team as a code owner May 29, 2024 21:16
@aqu-erp aqu-erp changed the title Add FOCUS dataset to glossary FOCUS dataset consistency review May 29, 2024
@aqu-erp aqu-erp requested a review from ijurica May 29, 2024 22:28
@jpradocueva jpradocueva added this to the v1.1 milestone May 31, 2024
@flanakin flanakin added the editorial Items that address editorial and minor changes label Jun 12, 2024
@ijurica
Copy link
Contributor

ijurica commented Jun 13, 2024

We've mentioned that if native/custom columns are present in the FOCUS dataset, they must be prefixed with 'x_'. Do we need to emphasize that, if present, custom columns must also be listed in the Metadata - Schema - Column Definition.

By the way, we've specified that each column is represented with a Column Name. Would Column IDs be more useful in this context?

@jpradocueva
Copy link
Contributor

jpradocueva commented Jun 18, 2024

Action Item

  • Maintainers-#474: Andrew to lead the review and discussions in Task Force 3.

@jpradocueva jpradocueva added the P1 label Jul 1, 2024
@jpradocueva
Copy link
Contributor

jpradocueva commented Jul 12, 2024

Action Items agreed on TF-3, July 12 call:

  • Maintainers-#474 : Andrew will lead the review and discussions in Task Force 3.
  • TF3- #474 All members to review and provide comments on the PR
  • TF3- #474 Members: Discuss and finalize the inclusion of native provider columns in the FOCUS dataset definition in the glossary.

Action Items from TF-3, July 19.

  • TF3-#474 Andrew: To update the PR with additional guidelines and links to the glossary.
  • Present the PR at the next members' meeting.

@jpradocueva
Copy link
Contributor

This PR was approved by the group during the Maintainers meeting on August 1.

@jpradocueva jpradocueva merged commit e0f2f16 into working_draft Aug 2, 2024
2 checks passed
@jpradocueva jpradocueva deleted the 472-FOCUS-dataset-consistency branch August 2, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Items that address editorial and minor changes
Projects
Status: W.I.P
Development

Successfully merging this pull request may close these issues.

5 participants