Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated SKU column (for issue #495) #516

Merged
merged 23 commits into from
Sep 20, 2024
Merged

Conversation

AWS-ZachErdman
Copy link
Contributor

@AWS-ZachErdman AWS-ZachErdman commented Aug 7, 2024

Lead Maintainer: Zach

Documents:

@AWS-ZachErdman AWS-ZachErdman requested a review from a team as a code owner August 7, 2024 20:48
@AWS-ZachErdman AWS-ZachErdman linked an issue Aug 7, 2024 that may be closed by this pull request
@jpradocueva jpradocueva added the P1 label Aug 7, 2024
@jpradocueva
Copy link
Contributor

jpradocueva commented Aug 7, 2024

Action Items from TF-2 call on Aug 7th:

  • [TF2- #516] Zach to update the PR #516 with a more detailed description and potential names for the new column.
  • [TF2- #516] Tim to gather additional feedback on the prioritization of features. This should address the need for better documentation and decision-making transparency.
  • [TF2- #516] Tim will provide feedback about the new column directly to the pull request
  • [TF2- #516] A spreadsheet will be created to list potential names and descriptions for the new column, allowing for community voting and feedback.
  • [TF2- #516] The team to revisit the introduction of additional columns in future versions based on user feedback and evolving needs.

Action Items from TF-2 meeting on Aug 14th:

  • [TF2-#495-#516 ] Tim and Karl to provide samples from GCP to illustrate how the new column will be used. This is part of the alignment of the SKU properties across providers.
  • [TF2-#495-#516 ] The group to finalize the PR for the new column by next week to ensure timely approval.
  • [TF2-#495-#516 ] Zach to draft a short narrative explaining the use case and goals of the new column, align it with the current PR, avoid specific provider terminology.
  • [TF2-#495-#516 ] Zach to incorporate into PR Dedicated SKU column (for issue #495) #516 the following concepts discussed and agreed by the group:
  1. Flexible Definition for the New Column:
    • The team agreed to adopt a flexible approach to defining the new usage type column. The definition would accommodate differences in how each cloud provider (AWS, Azure, GCP) defines and measures SKUs. The focus will be on describing the function of the SKU without being overly prescriptive.
  2. Incorporation of Provider-Specific Values:
    • It was acknowledged that the new column would likely contain provider-specific values, and the group agreed to embrace the inherent differences across providers. The goal is to allow these slightly disparate concepts to coexist within a single column, recognizing that this will not be a perfectly normalized field across all providers.
  3. Exclusion of Size and Tier for Now:
    • The group discussed the possibility of future columns such as size and tier, which could be introduced in later releases. For now, the decision was made not to include these elements in the new column being defined in PR Dedicated SKU column (for issue #495) #516.
  4. Narrative and Supporting Content:
    • Zach was tasked with drafting a narrative that would clearly define the use case and goals for the new column. This narrative should avoid specific provider terminology and instead focus on a more abstract description that applies across all cloud providers.
  5. Timeline and PR Update:
    • The team agreed that the updates and narrative provided by Zach would be incorporated into PR Dedicated SKU column (for issue #495) #516. The aim is to finalize the PR by the following week, ensuring that it reflects the group’s consensus and is ready for Task Force (TF) approval.
    • The PR would then be presented to the broader group for final approval, with the understanding that there is limited time remaining before the release deadline.

Action Items, Members', Aug 15:

  • [Members-#516 ] Zach to continue refining the PR and gather more feedback.

Action Items, Maintainers, Aug 19:

  • [Maintainer-#516] Zach, Michael will inalize the list of names and conduct a vote.

@jpradocueva
Copy link
Contributor

Action Items TF-2 call on 21 Aug:

  • [TF2-#516 Spreadshet] Zach @AWS-ZachErdman : To finalize the document with the proposed column names and structure and share it with the larger group for review.
  • [TF2-#516 Spreadshet] All Members: To review the document and provide feedback on the proposed naming conventions by the next meeting.

@jpradocueva jpradocueva added this to the v1.1 milestone Aug 22, 2024
@jpradocueva
Copy link
Contributor

Action Items, Members' call on Aug 22:

[Members-#516] Zach @AWS-ZachErdman : To prepare a poll and suggested names for the next meeting.

@jpradocueva
Copy link
Contributor

Action Items from Maintainers' call on Aug 26th:

  • [Maintainers-#516 ] Zach - @AWS-ZachErdman : To update the PR with the final name and revised language.

@jpradocueva
Copy link
Contributor

Action Items from TF-2 call on Aug 28:

  • [TF2-#516] Zach - @AWS-ZachErdman : Update the PR to reflect the new column name "SKU Meter" and refine the description to align with the discussion.
  • [TF2-#516] All Members: Review the updated PR and vote on the final column name and description by the next meeting.
  • [TF2-#516] Zach - @AWS-ZachErdman : Reach out to Sean, Irina, Michael, Tim, and other relevant members to gather their approval on the updated PR before the next meeting.

@AWS-ZachErdman AWS-ZachErdman changed the title initial draft of usage type Dedicated SKU column (for issue #495) Aug 30, 2024
@udam-f2
Copy link
Contributor

udam-f2 commented Sep 1, 2024

@AWS-ZachErdman Seems like we'll need a good amount of supporting content to be added here to capture all the discussions and how we ended up getting around to this.

@jpradocueva
Copy link
Contributor

Action Items from Maintainers' call on Sep 2:

  • [Maintainers-#516] Team members to gather further feedback on the preferred terminology and be prepared to discuss it in the next meeting.

@AWS-ZachErdman
Copy link
Contributor Author

@AWS-ZachErdman Seems like we'll need a good amount of supporting content to be added here to capture all the discussions and how we ended up getting around to this.

Added the content for review.

change from 9/4/ TF-2 meeting with Irena
specification/columns/skumetername.md Outdated Show resolved Hide resolved
specification/columns/skumetername.md Outdated Show resolved Hide resolved
supporting_content/columns/skumetername.md Outdated Show resolved Hide resolved
@jpradocueva
Copy link
Contributor

Action Items Maintainers' call on Sep 6:

  • [Maintainers-#516] Zach, @AWS-ZachErdman : Coordinate with Task Force 2 to review and finalize the UsageType draft before the next meeting.
  • [Maintainers-#516] Reporting Team: Assess how the UsageType changes will impact reporting across different providers.

@jpradocueva
Copy link
Contributor

Action Items from TF-2 call on Sep 11:

  • [TF1-#516] Zach, @AWS-ZachErdman : Prepare the PR for the naming revote and include a few additional options for clarity.
  • [TF1-#516] Michael, @flanakin : Provide alternative names for comparison to the team before the next meeting.

@jpradocueva
Copy link
Contributor

There is a problem compiling the PDF due to missing files: capacityreservationid.md and capacityreservationstatus.md

image

@rileyjenk
Copy link
Contributor

rileyjenk commented Sep 12, 2024

@AWS-ZachErdman you have examples in the supporting content, would it be good to add an example to the appendix/example section? Not critical but may help to identify the difference between this and other columns.

@jpradocueva
Copy link
Contributor

Action Items from Members' call on Feb 12:

  • [TF2-#516] Zach, @AWS-ZachErdman : Finalize any outstanding reviews and prepare for next week’s approval.

@jpradocueva
Copy link
Contributor

Approved by the Members' group on the Sep 19 call.

@udam-f2 udam-f2 merged commit 52abaeb into working_draft Sep 20, 2024
2 checks passed
@udam-f2 udam-f2 deleted the usage-or-function-type branch September 20, 2024 03:59
cnharris10 added a commit that referenced this pull request Sep 20, 2024
**Lead Maintainer**: Zach
### Documents: 
* Folder #495 : [SKU Properties & Providers
Alignment](https://drive.google.com/drive/u/0/folders/11CDin-7o7KNGrdCzgq7gdVwQFcJ2l8aq)
by Zach moved to folder #495
* Document: [SKU Details from Providers
(FOCUS)](https://docs.google.com/document/d/1PdF8VQ5Ad4kDmrTlSEzWGOitwyEeQHR5B13hPWArMg0/edit#heading=h.ezdq0hltg6)
* Spreadsheet: [24.08.08 -
Alternative-Column-Names-for-UsageType](https://docs.google.com/spreadsheets/d/1-n_-z1bWKKwEbSXfiICHl0ff-uC9qAdDaDYhQGsagEM/edit?usp=sharing)
* PR
[#516](#516)
Initial Draft of UsageType
* Approval date: Sep 05

---------

Co-authored-by: Christopher Harris <cnharris@gmail.com>
Co-authored-by: Joaquin <jprado@linuxfoundation.org>
Co-authored-by: Karl <133434112+kk09v@users.noreply.github.com>
Co-authored-by: Udam Dewaraja <udam@finops.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: W.I.P
Development

Successfully merging this pull request may close these issues.

SKU Properties & Providers alignment
9 participants