Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity Reservation Proposal for ID & Status #523

Conversation

gparker-at-sf
Copy link
Contributor

Proposal based on Action Items, TF-3, Aug 16:

[TF3-#397] George will draft a PR for the new “ID” and “Status” columns related to ODCRs.
[TF3-#397] to consult AWS for further guidance on the feasibility of providing a CR ID in the billing data.

@gparker-at-sf gparker-at-sf requested a review from a team as a code owner August 19, 2024 14:58
@jpradocueva jpradocueva added the P1 label Aug 19, 2024
@jpradocueva jpradocueva added this to the v1.1 milestone Aug 19, 2024
@jpradocueva
Copy link
Contributor

Action Items, Maintainers, Aug 19:

  • [Maintainers-#509-#523] Chris and Zach will refine the PR to reflect the decisions made and prepare for final approval.

@jpradocueva jpradocueva linked an issue Aug 22, 2024 that may be closed by this pull request
@gparker-at-sf gparker-at-sf changed the title ODCR Proposal for ID & Status Capacity Reservation Proposal for ID & Status Aug 22, 2024
@jpradocueva
Copy link
Contributor

Action Items from Member's call on Aug 22:

@jpradocueva
Copy link
Contributor

Action Items from TF-3 call on Aug 23rd:

  • [TF-3-#523 ] Zach, @AWS-ZachErdman : To update the PR based on the feedback, ensuring the language reflects the decisions made about when the ID and status must or should be provided.
  • [TF-3-#523 ] Chris - (@cnharris10), Alex - (@ahullah), Zach - (@AWS-ZachErdman), and Irena - (@ijurica): To review the updated PR and provide final comments or approvals.

@jpradocueva
Copy link
Contributor

Action Items from Maintainers' call on Aug 26:

ahullah and others added 2 commits August 27, 2024 12:22
@ijurica
Copy link
Contributor

ijurica commented Aug 29, 2024

There is no entry for Capacity Reservation in the Glossary.

According to FinOps terminology:

Capacity Reservation

Capacity Reservations allow you to secure compute capacity for resource instances in a particular region or zone. By utilizing Capacity Reservations, you can proactively address the potential challenge of acquiring capacity in situations where there might be capacity limitations. If you have specific capacity demands and operate mission-critical workloads that necessitate reliable and predictable capacity levels, it is advised that you create a Capacity Reservation. This ensures uninterrupted access to CSP instances, precisely when you require them. Capacity Reservations are available through on-demand Capacity Reservations (ODCRs) or through specific Commitment Discount types available from your CSP.

@jpradocueva
Copy link
Contributor

Action Items from the TF-3 call on Friday, Sep 30:

  • [TF3-#523] George: To update the PR by adding "Capacity Reservation" to the glossary and revising the requirements to avoid circular references and improve clarity.
  • [TF3-#523] Irina: To review and approve the final changes made to the PR.

Copy link
Contributor

@udam-f2 udam-f2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go once comments are addressed.

This definitely needs some supporting content added to capture why we're dancing around the need for the capacity reservation id being SHOULD and other important topics we discussed (e.g. should this be in generic columns, related resources etc.).

Because of the FOCUS recommendation to use forks (which is unfortunate and an unnecessary complication for no gain), can't suggest this directly - so adding here:
FYI @jpradocueva

Please add to columns.mdpp (in alphabetical order):

!INCLUDE "capacityreservationid.md",1
!INCLUDE "capacityreservationstatus.md",1

specification/glossary.md Outdated Show resolved Hide resolved
@jpradocueva
Copy link
Contributor

Action Items from Maintainers' call on Sep 2nd:

  • [Maintainers-#523] George, @gparker-at-sf will update the PR by adding “Capacity Reservation” to the glossary and Irena to review and approve the PR and revisit the suggestions during the consistency review.
  • [Maintainers-#523] Irena, @ijurica : To review and approve the final changes made to the PR.

gparker-at-sf and others added 3 commits September 3, 2024 11:29
Co-authored-by: Irena Jurica <irena.jurica@neos.hr>
Co-authored-by: Christopher Harris <cnharris@gmail.com>
Co-authored-by: Udam Dewaraja <udam@finops.org>
gparker-at-sf and others added 2 commits September 3, 2024 18:36
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
Co-authored-by: Christopher Harris <cnharris@gmail.com>
specification/glossary.md Outdated Show resolved Hide resolved
@jpradocueva
Copy link
Contributor

Approved by the Members group on Sep 5.

@jpradocueva jpradocueva merged commit 4467a23 into FinOps-Open-Cost-and-Usage-Spec:working_draft Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: W.I.P
Development

Successfully merging this pull request may close these issues.

How to represent ODCRs in FOCUS
9 participants